Sign upLogin

devrelcollective/xela

View on GitHub
Star
models/event.go

Summary

Maintainability
C
1 day
Test Coverage

TODO found
Open

    // TODO: Create a function using SHA and a salt for the new filename and use that instead of e.Logo.Filename below.
Severity: Minor
Found in models/event.go by fixme

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (e *Event) AfterCreate(tx *pop.Connection) error {
    if !e.Logo.Valid() {
        return nil
    }
Severity: Major
Found in models/event.go and 1 other location - About 4 hrs to fix
models/event.go on lines 102..130

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 325.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (e *Event) AfterUpdate(tx *pop.Connection) error {
    if !e.Logo.Valid() {
        return nil
    }
Severity: Major
Found in models/event.go and 1 other location - About 4 hrs to fix
models/event.go on lines 71..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 325.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

exported method Event.AfterCreate should have comment or be unexported
Open

func (e *Event) AfterCreate(tx *pop.Connection) error {
Severity: Minor
Found in models/event.go by golint

exported method Event.AfterUpdate should have comment or be unexported
Open

func (e *Event) AfterUpdate(tx *pop.Connection) error {
Severity: Minor
Found in models/event.go by golint

exported type Event should have comment or be unexported
Open

type Event struct {
Severity: Minor
Found in models/event.go by golint

There are no issues that match your filters.

Category
Status