Sign upLogin

devth/yetibot

View on GitHub
Star
src/yetibot/commands/emoji.clj

Summary

Maintainability
Test Coverage

Non-idiomatic code found in (if (coll? alias) nil (str alias))
Open

  (if-let [sanitized-alias (if (coll? alias)
Severity: Minor
Found in src/yetibot/commands/emoji.clj by kibit

Consider using:

(when-not (coll? alias) (str alias))

instead of:

(if (coll? alias) nil (str alias))

Non-idiomatic code found in (-> (reduce (fn [return-set emoji] (let [tag-vector (:tags emoji) tag-hash-set (set tag-vector)] (clojure.set/union return-set tag-hash-set))) #{} emojis) sort)
Open

  (-> (reduce (fn [return-set emoji]
Severity: Minor
Found in src/yetibot/commands/emoji.clj by kibit

Consider using:

(sort
  (reduce
    (fn [return-set emoji]
      (let [tag-vector (:tags emoji) tag-hash-set (set tag-vector)]
        (clojure.set/union return-set tag-hash-set)))
    #{}
    emojis))

instead of:

(-> (reduce
      (fn [return-set emoji]
        (let [tag-vector (:tags emoji) tag-hash-set (set tag-vector)]
          (clojure.set/union return-set tag-hash-set)))
      #{}
      emojis)
 sort)

Non-idiomatic code found in (if (or (empty? description) (coll? description)) nil (str description))
Open

  (if-let [sanitized-desc (if (or (empty? description)
Severity: Minor
Found in src/yetibot/commands/emoji.clj by kibit

Consider using:

(when-not (or (empty? description) (coll? description))
  (str description))

instead of:

(if (or (empty? description) (coll? description)) nil (str description))

There are no issues that match your filters.

Category
Status