Sign upLogin

devth/yetibot

View on GitHub
Star
src/yetibot/commands/pirate.clj

Summary

Maintainability
Test Coverage

Non-idiomatic code found in (apply str accum)
Open

        (apply str accum)
Severity: Minor
Found in src/yetibot/commands/pirate.clj by kibit

Consider using:

(clojure.string/join accum)

instead of:

(apply str accum)

Non-idiomatic code found in (-> (time/to-time-zone (time/now) (time/time-zone-for-id local-tz)) time/hour)
Open

  (let [hour (-> (time/to-time-zone (time/now) (time/time-zone-for-id local-tz))
Severity: Minor
Found in src/yetibot/commands/pirate.clj by kibit

Consider using:

(time/hour
  (time/to-time-zone (time/now) (time/time-zone-for-id local-tz)))

instead of:

(-> (time/to-time-zone (time/now) (time/time-zone-for-id local-tz))
 time/hour)

Non-idiomatic code found in (apply str (repeat (rand-nth [2 3]) c))
Open

                 (apply str (repeat (rand-nth [2 3]) c)))))
Severity: Minor
Found in src/yetibot/commands/pirate.clj by kibit

Consider using:

(clojure.string/join (repeat (rand-nth [2 3]) c))

instead of:

(apply str (repeat (rand-nth [2 3]) c))

Non-idiomatic code found in (if (re-find slur-re s) s nil)
Open

  (if (re-find slur-re s) s nil))
Severity: Minor
Found in src/yetibot/commands/pirate.clj by kibit

Consider using:

(when (re-find slur-re s) s)

instead of:

(if (re-find slur-re s) s nil)

There are no issues that match your filters.

Category
Status