Sign upLogin

dflydev/dflydev-finite-state-machine

View on GitHub
Star

Showing 14 of 14 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Dflydev\FiniteStateMachine\TransitionEvent;
Severity: Major
Found in src/TransitionEvent/TransitionEventCallbackResolver.php and 1 other location - About 2 hrs to fix
src/Guard/GuardCallbackResolver.php on lines 1..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Dflydev\FiniteStateMachine\Guard;
Severity: Major
Found in src/Guard/GuardCallbackResolver.php and 1 other location - About 2 hrs to fix
src/TransitionEvent/TransitionEventCallbackResolver.php on lines 1..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method load has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function load($resource): void
    {
        $stateCollection = new StateCollection();
        $transitionCollection = new TransitionCollection();
        $guardCollection = new GuardCollection();
Severity: Major
Found in src/Loader/WinzouArrayLoader.php - About 2 hrs to fix

    Function load has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function load($resource): void
    {
        $stateCollection = new StateCollection();
        $transitionCollection = new TransitionCollection();
        $guardCollection = new GuardCollection();
    Severity: Minor
    Found in src/Loader/WinzouArrayLoader.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method apply has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function apply(string $transition): void
    {
        $resolvedTransition = $this->resolveTransition($transition);

        $currentState = $this->currentState();
    Severity: Minor
    Found in src/FiniteStateMachine.php - About 1 hr to fix

      Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              string $className,
        string $graph,
        array $objectProxyOptions,
        array $metadata,
        StateCollection $stateCollection,
      Severity: Major
      Found in src/Graph/Graph.php - About 1 hr to fix

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                string $when,
        string $name,
        array $transitionNames,
        array $fromStateNames,
        array $toStateNames,
        Severity: Minor
        Found in src/TransitionEvent/TransitionEvent.php - About 45 mins to fix

          Method __invoke has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  string $when,
        object $object,
        Transition $transition,
        State $fromState,
        State $toState
          Severity: Minor
          Found in src/Contracts/TransitionEventCallback.php - About 35 mins to fix

            Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function __construct(Graph $graph, object $object, Transition $transition, State $fromState, State $toState)
            Severity: Minor
            Found in src/Event/EventBehavior.php - About 35 mins to fix

              Method fireIfMatches has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      string $when,
        object $object,
        Transition $transition,
        State $fromState,
        State $toState
              Severity: Minor
              Found in src/TransitionEvent/TransitionEvent.php - About 35 mins to fix

                Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        string $name,
        array $transitionNames,
        array $fromStateNames,
        array $toStateNames,
        GuardCallback $callback
                Severity: Minor
                Found in src/Guard/Guard.php - About 35 mins to fix

                  Method __invoke has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          string $when,
        object $object,
        Transition $transition,
        State $fromState,
        State $toState
                  Severity: Minor
                  Found in src/TransitionEvent/CallableTransitionEventCallback.php - About 35 mins to fix

                    Function fireIfMatches has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function fireIfMatches(
        string $when,
        object $object,
        Transition $transition,
        State $fromState,
                    Severity: Minor
                    Found in src/TransitionEvent/TransitionEvent.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function for has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function for(object $object, string $graph = 'default'): Graph
    {
        $className = get_class($object);

        foreach ($this->graphsByName as $classNameForGraph => $graphs) {
                    Severity: Minor
                    Found in src/Graph/GraphCollection.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language