Sign upLogin

dgarlitt/karma-nyan-reporter

View on GitHub
Star

Showing 10 of 10 total issues

Function DrawUtil has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

function DrawUtil(numOfLines) {
  var width = shell.getWidth() * 0.75 | 0;
  var maxHeight = shell.getHeight() - 1;

  this.numberOfLines = Math.max(4, Math.min(numOfLines, maxHeight));
Severity: Minor
Found in lib/util/draw.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function DrawUtil has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function DrawUtil(numOfLines) {
  var width = shell.getWidth() * 0.75 | 0;
  var maxHeight = shell.getHeight() - 1;

  this.numberOfLines = Math.max(4, Math.min(numOfLines, maxHeight));
Severity: Major
Found in lib/util/draw.js - About 3 hrs to fix

    Function ShellUtility has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var ShellUtility = function() {
  var self = this;
  var winSize = useStdout ? stdout.getWindowSize(1) : [75, 4];

  this.getWidth = function() {
    Severity: Minor
    Found in lib/util/shell.js - About 1 hr to fix

      Function onSpecComplete has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      NyanCat.prototype.onSpecComplete = function(browser, result) {
  // don't pollute original object
  this.stats = Object.create(browser.lastResult);

  // sum up tests stats
      Severity: Minor
      Found in lib/nyanCat.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          this.suites.forEach(function(suite) {
    out.push(suite.toString().trim());
    out.push('');
  });
        Severity: Major
        Found in lib/data/types.js and 1 other location - About 1 hr to fix
        lib/data/types.js on lines 57..60

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          this.tests.forEach(function(test) {
    out.push(test.toString().trim());
    out.push('');
  });
        Severity: Major
        Found in lib/data/types.js and 1 other location - About 1 hr to fix
        lib/data/types.js on lines 62..65

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function printBrowserErrors has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function printBrowserErrors(rainbowify, browserErrors) {
    if (rainbowify && browserErrors)  {
      var hashes = '##########'.split('');
      var rainbowifyEach = function(val) {
        write(rainbowify(val));
        Severity: Minor
        Found in lib/util/printers.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          function Test(name) {
  this.name = name.trim();
  this.depth = 0;
  this.browsers = [];
}
          Severity: Minor
          Found in lib/data/types.js and 1 other location - About 50 mins to fix
          lib/data/types.js on lines 111..115

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          function Browser(name) {
  this.name = name.trim();
  this.depth = 0;
  this.errors = [];
}
          Severity: Minor
          Found in lib/data/types.js and 1 other location - About 50 mins to fix
          lib/data/types.js on lines 84..88

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function printBrowserErrors has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            function printBrowserErrors(rainbowify, browserErrors) {
    if (rainbowify && browserErrors)  {
      var hashes = '##########'.split('');
      var rainbowifyEach = function(val) {
        write(rainbowify(val));
          Severity: Minor
          Found in lib/util/printers.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language