Sign upLogin

dhgwilliam/google-voice-stats

View on GitHub
Star

Showing 371 of 371 total issues

Avoid too many return statements within this function.
Open

                return ( context || rootjQuery ).find( selector );
Severity: Major
Found in public/js/jquery.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return this.constructor( context ).find( selector );
    Severity: Major
    Found in public/js/jquery.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return event.result;
      Severity: Major
      Found in public/js/jquery.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                                return true;
        Severity: Major
        Found in public/js/jquery.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return ret;
          Severity: Major
          Found in public/js/jquery.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return { top: top, left: left };
            Severity: Major
            Found in public/js/jquery.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return text.substring(j);
              Severity: Major
              Found in public/js/d3.v2.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return this.each(d3_selection_classed(name, value));
                Severity: Major
                Found in public/js/d3.v2.js - About 30 mins to fix

                  Method save! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def save!
    if @sender && @recipient
      sender    = Person.with(:name, @sender) || Person.create(:name => @sender)
      recipient = Person.with(:name, @recipient) || Person.create(:name => @recipient)
      begin
                  Severity: Minor
                  Found in models/person.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  get '/weekly' do
  # response['Cache-Control'] = "public, max-age=" + (60*60*24).to_s
  @segments = person_by(nil, "week")
  @time_period = @segments[1]
  @segments = @segments[0]
                  Severity: Minor
                  Found in routes.rb and 1 other location - About 25 mins to fix
                  routes.rb on lines 31..38

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 29.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  get '/monthly' do
  # response['Cache-Control'] = "public, max-age=" + (60*60*24).to_s
  @segments = person_by(nil, "month")
  @time_period = @segments[1]
  @segments = @segments[0]
                  Severity: Minor
                  Found in routes.rb and 1 other location - About 25 mins to fix
                  routes.rb on lines 49..56

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 29.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language