Sign upLogin

dhhxu/projectscope

View on GitHub
Star
app/controllers/projects_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Method has too many lines. [56/30]
Open

  def index
    sort = params[:sort] || session[:sort]
    if params[:sort] == nil
      session[:sort] == nil
    end
Severity: Minor
Found in app/controllers/projects_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method index has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

  def index
    sort = params[:sort] || session[:sort]
    if params[:sort] == nil
      session[:sort] == nil
    end
Severity: Minor
Found in app/controllers/projects_controller.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for index is too high. [21/6]
Open

  def index
    sort = params[:sort] || session[:sort]
    if params[:sort] == nil
      session[:sort] == nil
    end
Severity: Minor
Found in app/controllers/projects_controller.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method index has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def index
    sort = params[:sort] || session[:sort]
    if params[:sort] == nil
      session[:sort] == nil
    end
Severity: Major
Found in app/controllers/projects_controller.rb - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

          if session[:sort] == 'pts'
        @projects = Project.includes(:pivotal_tracker).order("pivotal_trackers.score desc")
        session[:sort] = 'dpts'
      else
        @projects = Project.includes(:pivotal_tracker).order("pivotal_trackers.score asc")
    Severity: Major
    Found in app/controllers/projects_controller.rb - About 45 mins to fix

      FIXME found
      Open

            # FIXME
      Severity: Minor
      Found in app/controllers/projects_controller.rb by fixme

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

        def create
    @project = Project.new(project_params)

    respond_to do |format|
      if @project.save
      Severity: Major
      Found in app/controllers/projects_controller.rb and 5 other locations - About 1 hr to fix
      app/controllers/pivotal_trackers_controller.rb on lines 23..32
      app/controllers/pull_requests_controller.rb on lines 23..32
      app/controllers/slack_data_points_controller.rb on lines 23..32
      app/controllers/slack_metrics_controller.rb on lines 26..35
      app/controllers/slack_trends_controller.rb on lines 26..35

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

        def update
    respond_to do |format|
      if @project.update(project_params)
        format.html { redirect_to @project, notice: 'Project was successfully updated.' }
        format.json { render :show, status: :ok, location: @project }
      Severity: Major
      Found in app/controllers/projects_controller.rb and 5 other locations - About 55 mins to fix
      app/controllers/pivotal_trackers_controller.rb on lines 38..45
      app/controllers/pull_requests_controller.rb on lines 38..45
      app/controllers/slack_data_points_controller.rb on lines 38..45
      app/controllers/slack_metrics_controller.rb on lines 42..49
      app/controllers/slack_trends_controller.rb on lines 42..49

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 44.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            if session[:sort] == 'gpa'
        @projects = Project.includes(:code_climate_metric).order("code_climate_metrics.gpa desc")
        session[:sort] = 'dgpa'
      else
        @projects = Project.includes(:code_climate_metric).order("code_climate_metrics.gpa asc")
      Severity: Minor
      Found in app/controllers/projects_controller.rb and 3 other locations - About 20 mins to fix
      app/controllers/projects_controller.rb on lines 20..25
      app/controllers/projects_controller.rb on lines 28..33
      app/controllers/projects_controller.rb on lines 36..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            if session[:sort] == 'pts'
        @projects = Project.includes(:pivotal_tracker).order("pivotal_trackers.score desc")
        session[:sort] = 'dpts'
      else
        @projects = Project.includes(:pivotal_tracker).order("pivotal_trackers.score asc")
      Severity: Minor
      Found in app/controllers/projects_controller.rb and 3 other locations - About 20 mins to fix
      app/controllers/projects_controller.rb on lines 12..17
      app/controllers/projects_controller.rb on lines 20..25
      app/controllers/projects_controller.rb on lines 28..33

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            if session[:sort] == 'coverage'
        @projects = Project.includes(:code_climate_metric).order("code_climate_metrics.coverage desc")
        session[:sort] = 'dcoverage'
      else
        @projects = Project.includes(:code_climate_metric).order("code_climate_metrics.coverage asc")
      Severity: Minor
      Found in app/controllers/projects_controller.rb and 3 other locations - About 20 mins to fix
      app/controllers/projects_controller.rb on lines 12..17
      app/controllers/projects_controller.rb on lines 28..33
      app/controllers/projects_controller.rb on lines 36..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            if session[:sort] == 'prs'
        @projects = Project.includes(:pull_request).order("pull_requests.score desc")
        session[:sort] = 'dprs'
      else
        @projects = Project.includes(:pull_request).order("pull_requests.score asc")
      Severity: Minor
      Found in app/controllers/projects_controller.rb and 3 other locations - About 20 mins to fix
      app/controllers/projects_controller.rb on lines 12..17
      app/controllers/projects_controller.rb on lines 20..25
      app/controllers/projects_controller.rb on lines 36..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status