dianhua1560/bhgh

View on GitHub

Showing 208 of 208 total issues

float can't be used with display: inline-block.
Open

    float:bottom;
Severity: Minor
Found in app/assets/stylesheets/main.css by csslint

Missing standard property 'box-shadow' to go along with '-webkit-box-shadow'.
Open

    -webkit-box-shadow: 0px 0px 8px 2px rgba(0,0,0,0.3);
Severity: Minor
Found in app/assets/stylesheets/main.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

#main-row:after {
Severity: Minor
Found in app/assets/stylesheets/main.css by csslint

Use of !important
Open

    background-color:#fafafa !important;
Severity: Minor
Found in app/assets/stylesheets/main.css by csslint

float can't be used with display: inline-block.
Open

    float:right;
Severity: Minor
Found in app/assets/stylesheets/main.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

.more-info-dropdown{
Severity: Minor
Found in app/assets/stylesheets/main.css by csslint

Values of 0 shouldn't have units specified.
Open

    box-shadow: 0px 8px 16px 0px rgba(0,0,0,0.2);
Severity: Minor
Found in app/assets/stylesheets/main.css by csslint

Don't use IDs in selectors.
Open

#searchicon:hover {
Severity: Minor
Found in app/assets/stylesheets/main.css by csslint

Don't use IDs in selectors.
Open

#main-row:after {
Severity: Minor
Found in app/assets/stylesheets/main.css by csslint

Values of 0 shouldn't have units specified.
Open

    border-radius:0px;
Severity: Minor
Found in app/assets/stylesheets/main.css by csslint

Adjoining classes: nav.navbar.navbar-default.navbar-fixed-top
Open

nav.navbar.navbar-default.navbar-fixed-top{
Severity: Minor
Found in app/assets/stylesheets/main.css by csslint

Use of !important
Open

    background-color: #F8FDFF !important;
Severity: Minor
Found in app/assets/stylesheets/main.css by csslint

end at 75, 2 is not aligned with def at 70, 3.
Open

  end

This cop checks whether the end keywords of method definitions are aligned properly.

Two modes are supported through the EnforcedStyleAlignWith configuration parameter. If it's set to start_of_line (which is the default), the end shall be aligned with the start of the line where the def keyword is. If it's set to def, the end shall be aligned with the def keyword.

Example: EnforcedStyleAlignWith: startofline (default)

# bad

private def foo
            end

# good

private def foo
end

Example: EnforcedStyleAlignWith: def

# bad

private def foo
            end

# good

private def foo
        end

end at 53, 4 is not aligned with if at 47, 2.
Open

          end
Severity: Minor
Found in app/controllers/brags_controller.rb by rubocop

This cop checks whether the end keywords are aligned properly.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

Example: EnforcedStyleAlignWith: keyword (default)

# bad

variable = if true
    end

# good

variable = if true
           end

Example: EnforcedStyleAlignWith: variable

# bad

variable = if true
    end

# good

variable = if true
end

Example: EnforcedStyleAlignWith: startofline

# bad

variable = if true
    end

# good

puts(if true
end)

Use of !important
Open

    padding-top:0px !important;
Severity: Minor
Found in app/assets/stylesheets/main.css by csslint

Values of 0 shouldn't have units specified.
Open

    border-radius:0px !important;
Severity: Minor
Found in app/assets/stylesheets/main.css by csslint

Rule doesn't have all its properties in alphabetical order.
Open

.box{
Severity: Minor
Found in app/assets/stylesheets/main.css by csslint

Expected '===' and instead saw '=='.
Open

        if(has_errors && error_type == 'event'){
Severity: Minor
Found in public/controllers/boardCtrl.js by eslint

Require === and !== (eqeqeq)

It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

  • [] == false
  • [] == ![]
  • 3 == "03"

If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

Rule Details

This rule is aimed at eliminating the type-unsafe equality operators.

Examples of incorrect code for this rule:

/*eslint eqeqeq: "error"*/

if (x == 42) { }

if ("" == text) { }

if (obj.getStuff() != undefined) { }

The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

Options

always

The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

Examples of incorrect code for the "always" option:

/*eslint eqeqeq: ["error", "always"]*/

a == b
foo == true
bananas != 1
value == undefined
typeof foo == 'undefined'
'hello' != 'world'
0 == 0
true == true
foo == null

Examples of correct code for the "always" option:

/*eslint eqeqeq: ["error", "always"]*/

a === b
foo === true
bananas !== 1
value === undefined
typeof foo === 'undefined'
'hello' !== 'world'
0 === 0
true === true
foo === null

This rule optionally takes a second argument, which should be an object with the following supported properties:

  • "null": Customize how this rule treats null literals. Possible values:
    • always (default) - Always use === or !==.
    • never - Never use === or !== with null.
    • ignore - Do not apply this rule to null.

smart

The "smart" option enforces the use of === and !== except for these cases:

  • Comparing two literal values
  • Evaluating the value of typeof
  • Comparing against null

Examples of incorrect code for the "smart" option:

/*eslint eqeqeq: ["error", "smart"]*/

// comparing two variables requires ===
a == b

// only one side is a literal
foo == true
bananas != 1

// comparing to undefined requires ===
value == undefined

Examples of correct code for the "smart" option:

/*eslint eqeqeq: ["error", "smart"]*/

typeof foo == 'undefined'
'hello' != 'world'
0 == 0
true == true
foo == null

allow-null

Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

["error", "always", {"null": "ignore"}]

When Not To Use It

If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

Values of 0 shouldn't have units specified.
Open

    -webkit-box-shadow: 0px 0px 8px 2px rgba(100,100,100,0.3);
Severity: Minor
Found in app/assets/stylesheets/main.css by csslint

Expected '!==' and instead saw '!='.
Open

                    return x.id != response.id;
Severity: Minor
Found in public/controllers/boardCtrl.js by eslint

Require === and !== (eqeqeq)

It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

  • [] == false
  • [] == ![]
  • 3 == "03"

If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

Rule Details

This rule is aimed at eliminating the type-unsafe equality operators.

Examples of incorrect code for this rule:

/*eslint eqeqeq: "error"*/

if (x == 42) { }

if ("" == text) { }

if (obj.getStuff() != undefined) { }

The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

Options

always

The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

Examples of incorrect code for the "always" option:

/*eslint eqeqeq: ["error", "always"]*/

a == b
foo == true
bananas != 1
value == undefined
typeof foo == 'undefined'
'hello' != 'world'
0 == 0
true == true
foo == null

Examples of correct code for the "always" option:

/*eslint eqeqeq: ["error", "always"]*/

a === b
foo === true
bananas !== 1
value === undefined
typeof foo === 'undefined'
'hello' !== 'world'
0 === 0
true === true
foo === null

This rule optionally takes a second argument, which should be an object with the following supported properties:

  • "null": Customize how this rule treats null literals. Possible values:
    • always (default) - Always use === or !==.
    • never - Never use === or !== with null.
    • ignore - Do not apply this rule to null.

smart

The "smart" option enforces the use of === and !== except for these cases:

  • Comparing two literal values
  • Evaluating the value of typeof
  • Comparing against null

Examples of incorrect code for the "smart" option:

/*eslint eqeqeq: ["error", "smart"]*/

// comparing two variables requires ===
a == b

// only one side is a literal
foo == true
bananas != 1

// comparing to undefined requires ===
value == undefined

Examples of correct code for the "smart" option:

/*eslint eqeqeq: ["error", "smart"]*/

typeof foo == 'undefined'
'hello' != 'world'
0 == 0
true == true
foo == null

allow-null

Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

["error", "always", {"null": "ignore"}]

When Not To Use It

If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

Severity
Category
Status
Source
Language