Sign upLogin

dice-cyfronet/atmosphere

View on GitHub
Star
app/controllers/atmosphere/api/v1/appliances_controller.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Class AppliancesController has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

class Atmosphere::Api::V1::AppliancesController < Atmosphere::Api::ApplicationController
  before_action :build_appliance, only: :create

  load_and_authorize_resource :appliance,
                              class: 'Atmosphere::Appliance'
Severity: Minor
Found in app/controllers/atmosphere/api/v1/appliances_controller.rb - About 3 hrs to fix

    Method action has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def action
    return reboot if reboot_action?
    return scale if scale_action?
    return pause if pause_action?
    return stop if stop_action?
    Severity: Minor
    Found in app/controllers/atmosphere/api/v1/appliances_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

        return suspend if suspend_action?
    Severity: Major
    Found in app/controllers/atmosphere/api/v1/appliances_controller.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return start if start_action?
      Severity: Major
      Found in app/controllers/atmosphere/api/v1/appliances_controller.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status