Sign upLogin

dice-cyfronet/atmosphere

View on GitHub
Star
app/providers/atmosphere/optimization_strategy/default.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method select has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

        def select
          best_template = nil
          best_tenant = nil
          best_flavor = nil
          instantiation_cost = Float::INFINITY
Severity: Minor
Found in app/providers/atmosphere/optimization_strategy/default.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method select has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def select
          best_template = nil
          best_tenant = nil
          best_flavor = nil
          instantiation_cost = Float::INFINITY
Severity: Minor
Found in app/providers/atmosphere/optimization_strategy/default.rb - About 1 hr to fix

    Method get_optimal_flavor_for_tenant has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def get_optimal_flavor_for_tenant(tmpl, t)
          mfs = matching_flavors(tmpl, t)
          best_cost = Float::INFINITY
          best_mem = Float::INFINITY
          opt_fl = nil
    Severity: Minor
    Found in app/providers/atmosphere/optimization_strategy/default.rb - About 1 hr to fix

      Method get_optimal_flavor_for_tenant has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

              def get_optimal_flavor_for_tenant(tmpl, t)
          mfs = matching_flavors(tmpl, t)
          best_cost = Float::INFINITY
          best_mem = Float::INFINITY
          opt_fl = nil
      Severity: Minor
      Found in app/providers/atmosphere/optimization_strategy/default.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_candidate_tenants_for_template has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

              def get_candidate_tenants_for_template(tmpl)
          # Determine which tenants can be used to spawn this specific template in the context
          # of the current @appliance.
          # If @appliance is nil (which may happen) return active tenants:
          if @appliance.blank?
      Severity: Minor
      Found in app/providers/atmosphere/optimization_strategy/default.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status