dictyBase/modware-order

View on GitHub
internal/app/service/service.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method OrderService.orderQueryWithFilter has 60 lines of code (exceeds 50 allowed). Consider refactoring.
Invalid

func (s *OrderService) orderQueryWithFilter(
    ctx context.Context,
    params *order.ListParameters,
) (*order.OrderCollection, error) {
    orc := &order.OrderCollection{}
Severity: Minor
Found in internal/app/service/service.go - About 1 hr to fix

    Method OrderService.orderQueryWithFilter has 6 return statements (exceeds 4 allowed).
    Invalid

    func (s *OrderService) orderQueryWithFilter(
        ctx context.Context,
        params *order.ListParameters,
    ) (*order.OrderCollection, error) {
        orc := &order.OrderCollection{}
    Severity: Major
    Found in internal/app/service/service.go - About 40 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Invalid

      func (s *OrderService) CreateOrder(
          ctx context.Context,
          rdr *order.NewOrder,
      ) (*order.Order, error) {
          ord := &order.Order{}
      Severity: Major
      Found in internal/app/service/service.go and 2 other locations - About 2 hrs to fix
      internal/app/service/service.go on lines 97..116
      internal/app/service/service.go on lines 272..291

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 217.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Invalid

      func (s *OrderService) LoadOrder(
          ctx context.Context,
          rxo *order.ExistingOrder,
      ) (*order.Order, error) {
          ord := &order.Order{}
      Severity: Major
      Found in internal/app/service/service.go and 2 other locations - About 2 hrs to fix
      internal/app/service/service.go on lines 75..94
      internal/app/service/service.go on lines 97..116

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 217.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Invalid

      func (s *OrderService) UpdateOrder(
          ctx context.Context,
          urd *order.OrderUpdate,
      ) (*order.Order, error) {
          ord := &order.Order{}
      Severity: Major
      Found in internal/app/service/service.go and 2 other locations - About 2 hrs to fix
      internal/app/service/service.go on lines 75..94
      internal/app/service/service.go on lines 272..291

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 217.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          for _, item := range mlo {
              ocdata = append(ocdata, &order.OrderCollection_Data{
                  Type: s.GetResourceName(),
                  Id:   item.Key,
                  Attributes: &order.OrderAttributes{
      Severity: Major
      Found in internal/app/service/service.go and 1 other location - About 2 hrs to fix
      internal/app/service/service.go on lines 151..170

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 191.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          for _, item := range mlo {
              ocdata = append(ocdata, &order.OrderCollection_Data{
                  Type: s.GetResourceName(),
                  Id:   item.Key,
                  Attributes: &order.OrderAttributes{
      Severity: Major
      Found in internal/app/service/service.go and 1 other location - About 2 hrs to fix
      internal/app/service/service.go on lines 203..222

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 191.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status