Sign upLogin

diffux/diffux

View on GitHub
Star

Showing 579 of 579 total issues

Avoid too many return statements within this function.
Open

            return ret == null ?
                undefined :
                ret;
Severity: Major
Found in bower_components/jquery/dist/jquery.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return this;
    Severity: Major
    Found in bower_components/jquery/src/core/init.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return jQuery.makeArray( selector, this );
      Severity: Major
      Found in bower_components/jquery/src/core/init.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return results;
        Severity: Major
        Found in bower_components/jquery/src/sizzle/dist/sizzle.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                              return results;
          Severity: Major
          Found in bower_components/jquery/src/sizzle/dist/sizzle.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return compare & 4 ? -1 : 1;
            Severity: Major
            Found in bower_components/jquery/src/sizzle/dist/sizzle.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return this.constructor( context ).find( selector );
              Severity: Major
              Found in bower_components/jquery/src/core/init.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return typeof rootjQuery.ready !== "undefined" ?
                rootjQuery.ready( selector ) :
                // Execute immediately if ready is not present
                selector( jQuery );
                Severity: Major
                Found in bower_components/jquery/src/core/init.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return a.compareDocumentPosition ? -1 : 1;
                  Severity: Major
                  Found in bower_components/jquery/src/selector-native.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return select( selector.replace( rtrim, "$1" ), context, results, seed );
                    Severity: Major
                    Found in bower_components/jquery/src/sizzle/dist/sizzle.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return compare & 4 ? -1 : 1;
                      Severity: Major
                      Found in bower_components/jquery/src/selector-native.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return sortInput ?
                ( indexOf( sortInput, a ) - indexOf( sortInput, b ) ) :
                0;
                        Severity: Major
                        Found in bower_components/jquery/src/sizzle/dist/sizzle.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                          return results;
                          Severity: Major
                          Found in bower_components/jquery/src/sizzle/dist/sizzle.js - About 30 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                            function createFxNow() {
    setTimeout(function() {
        fxNow = undefined;
    });
    return ( fxNow = jQuery.now() );
                            Severity: Minor
                            Found in bower_components/jquery/src/effects.js and 1 other location - About 30 mins to fix
                            bower_components/jquery/dist/jquery.js on lines 6326..6331

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 45.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Identical blocks of code found in 2 locations. Consider refactoring.
                            Open

                            support.sortStable = expando.split("").sort( sortOrder ).join("") === expando;
                            Severity: Minor
                            Found in bower_components/jquery/src/sizzle/dist/sizzle.js and 1 other location - About 30 mins to fix
                            bower_components/jquery/dist/jquery.js on lines 2549..2549

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 45.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                            function createFxNow() {
    setTimeout(function() {
        fxNow = undefined;
    });
    return ( fxNow = jQuery.now() );
                            Severity: Minor
                            Found in bower_components/jquery/dist/jquery.js and 1 other location - About 30 mins to fix
                            bower_components/jquery/src/effects.js on lines 75..80

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 45.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Identical blocks of code found in 2 locations. Consider refactoring.
                            Open

                            support.sortStable = expando.split("").sort( sortOrder ).join("") === expando;
                            Severity: Minor
                            Found in bower_components/jquery/dist/jquery.js and 1 other location - About 30 mins to fix
                            bower_components/jquery/src/sizzle/dist/sizzle.js on lines 1996..1996

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 45.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Method sweep_status has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                              def sweep_status(sweep)
    if sweep.count_pending > 0
      t(:snapshots_pending, count: sweep.count_pending)
    elsif sweep.count_under_review > 0
      t(:snapshots_under_review, count: sweep.count_under_review)
                            Severity: Minor
                            Found in app/helpers/sweeps_helper.rb - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Method destroy_orphans! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                              def self.destroy_orphans!(klass: raise, parent: raise, dryrun: true)
    klass.all.includes(parent).each do |obj|
      if obj.send(parent).blank?
        if dryrun
          puts "(dryrun) would have deleted #{klass} with id #{obj.id}"
                            Severity: Minor
                            Found in app/services/db_cleanup.rb - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language