Sign upLogin

digidentity/libsaml

View on GitHub
Star
lib/saml/xml_helpers.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method to_xml has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def to_xml(*args)
      options                              = args.extract_options!
      builder, default_namespace, instruct = args
      instruct                             = true if instruct.nil?
Severity: Minor
Found in lib/saml/xml_helpers.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_soap has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def to_soap(options = {})
      builder = Nokogiri::XML::Builder.new
      body    = self.to_xml(builder)

      builder = Nokogiri::XML::Builder.new(encoding: "UTF-8")
Severity: Minor
Found in lib/saml/xml_helpers.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status