Sign upLogin

digidotcom/python-wvalib

View on GitHub
Star

Showing 16 of 16 total issues

File cli.py has 423 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python
#
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
Severity: Minor
Found in wva/cli.py - About 6 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    @cli.command()
@click.argument('uri')
@click.argument('input_file', type=click.File())
@click.pass_context
def post(ctx, uri, input_file):
    Severity: Major
    Found in wva/cli.py and 1 other location - About 3 hrs to fix
    wva/cli.py on lines 234..253

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    @cli.command()
@click.argument('uri')
@click.argument('input_file', type=click.File())
@click.pass_context
def put(ctx, uri, input_file):
    Severity: Major
    Found in wva/cli.py and 1 other location - About 3 hrs to fix
    wva/cli.py on lines 220..231

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def post_json(self, uri, data, **kwargs):
        """POST the provided data as json to the specified path

        See :meth:`request` for additional details.
        """
    Severity: Major
    Found in wva/http_client.py and 1 other location - About 2 hrs to fix
    wva/http_client.py on lines 164..173

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def put_json(self, uri, data, **kwargs):
        """PUT the provided data as json to the specified path

        See :meth:`request` for additional details.
        """
    Severity: Major
    Found in wva/http_client.py and 1 other location - About 2 hrs to fix
    wva/http_client.py on lines 145..154

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    @cli.command()
@click.argument('uri')
@click.pass_context
def delete(ctx, uri):
    """DELETE the specified URI
    Severity: Major
    Found in wva/cli.py and 1 other location - About 2 hrs to fix
    wva/cli.py on lines 158..196

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    @cli.command()
@click.argument('uri')
@click.pass_context
def get(ctx, uri):
    """Perform an HTTP GET of the provided URI
    Severity: Major
    Found in wva/cli.py and 1 other location - About 2 hrs to fix
    wva/cli.py on lines 199..217

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function list has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def list(ctx, value, timestamp):
    for name, element in sorted(get_wva(ctx).get_vehicle_data_elements().items(), key=lambda (k, v): k):
        if value:
            try:
                curval = element.sample()
    Severity: Minor
    Found in wva/cli.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _service_connected has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def _service_connected(self):
        # grab new data
        try:
            data = self._socket.recv(1024)
        except socket.timeout:
    Severity: Minor
    Found in wva/stream.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function cli has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def cli(ctx, hostname, username, password, config_dir, https):
    Severity: Minor
    Found in wva/cli.py - About 45 mins to fix

      Function sample has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def sample(ctx, element, timestamp, repeat, delay):
      Severity: Minor
      Found in wva/cli.py - About 35 mins to fix

        Function add has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def add(ctx, short_name, uri, interval, buffer):
        Severity: Minor
        Found in wva/cli.py - About 35 mins to fix

          Function get_config_value has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def get_config_value(ctx, key, prompt, current_value, password=False):
          Severity: Minor
          Found in wva/cli.py - About 35 mins to fix

            Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def run(self):
        fig, ax = plt.subplots()
        plt.suptitle("WVA Vehicle Data (Live Graph)")
        x = np.arange(-200, self._seconds, 0.01)
        plot_lines = {}
            Severity: Minor
            Found in wva/grapher.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function sample has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def sample(ctx, element, timestamp, repeat, delay):
    """Sample the value of a vehicle data element

This command allows for the current value of a vehicle data element
to be sampled:
            Severity: Minor
            Found in wva/cli.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function get_wva has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def get_wva(ctx):
    root_ctx = get_root_ctx(ctx)
    if root_ctx.wva is None:
        root_ctx.hostname = get_hostname(root_ctx)
        root_ctx.username = get_username(root_ctx)
            Severity: Minor
            Found in wva/cli.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language