Sign upLogin

digipolisgent/robo-digipolis-general

View on GitHub
Star

Showing 10 of 10 total issues

Method run has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run()
    {
        try {
            $this->finder->in($this->dirs)->files();
            $defaults = clone $this->finder;
Severity: Minor
Found in src/ReadProperties.php - About 1 hr to fix

    Function readProperties has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function readProperties($root = null, $web = null, $vendor = null)
    {
        if (!$this->getConfig()->get('digipolis.properties.read', false)) {
            if (is_null($root)) {
                if (is_callable([$this, 'taskDetermineProjectRoot'])) {
    Severity: Minor
    Found in src/Common/DigipolisPropertiesAware.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parseConfigFiles has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function parseConfigFiles(Finder $files)
    {
        $configs = [];
        foreach ($files as $file) {
            // Check if this is part of a Robo package.
    Severity: Minor
    Found in src/ReadProperties.php - About 1 hr to fix

      Each class must be in a namespace of at least one level (a top-level vendor name)
      Open

      class RoboFile extends \Robo\Tasks
      Severity: Minor
      Found in RoboFile.php by phpcodesniffer

      Missing class import via use statement (line '122', column '22').
      Open

                      [new \Grasmash\Expander\Expander(), 'expandArrayProperties'];
      Severity: Minor
      Found in src/ReadProperties.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function run()
    {
        $finder = clone $this->finder;
        $finder->in([$this->dir])->exclude($this->exclude)->depth('<=' . $this->depth)->files();
        $rootCandidates = [];
      Severity: Minor
      Found in src/DetermineProjectRoot.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function parseConfigFiles has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function parseConfigFiles(Finder $files)
    {
        $configs = [];
        foreach ($files as $file) {
            // Check if this is part of a Robo package.
      Severity: Minor
      Found in src/ReadProperties.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Code block style
      Open

          public function myCommand(
      Severity: Info
      Found in README.md by markdownlint

      Opening parenthesis of a multi-line function call must be the last content on the line
      Open

                  $parsedConfig = call_user_func($expander,
      Severity: Minor
      Found in src/ReadProperties.php by phpcodesniffer

      Line indented incorrectly; expected at least 12 spaces, found 10
      Open

                return [];
      Severity: Minor
      Found in src/ReadProperties.php by phpcodesniffer
      Severity
      Category
      Status
      Source
      Language