Sign upLogin

digipolisgent/robo-digipolis-package

View on GitHub
Star

Showing 18 of 18 total issues

Method run has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run()
    {
        // Print the output of the compile commands.
        $this->printed();
        if (file_exists($this->dir . '/Gemfile')) {
Severity: Major
Found in src/ThemeCompile.php - About 2 hrs to fix

    Method run has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function run()
    {
        // Clean bower cache before removing node_modules.
        $result = false;
        if (file_exists($this->dir . '/bower.json')) {
    Severity: Major
    Found in src/ThemeClean.php - About 2 hrs to fix

      Function mirrorDir has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function mirrorDir()
    {
        if (!$this->useTmpDir) {
            $this->tmpDir = $this->dir;
            return;
      Severity: Minor
      Found in src/PackageProject.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method mirrorDir has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function mirrorDir()
    {
        if (!$this->useTmpDir) {
            $this->tmpDir = $this->dir;
            return;
      Severity: Minor
      Found in src/PackageProject.php - About 1 hr to fix

        Each class must be in a namespace of at least one level (a top-level vendor name)
        Open

        class RoboFile extends \Robo\Tasks
        Severity: Minor
        Found in RoboFile.php by phpcodesniffer

        Function run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function run()
    {
        // Print the output of the compile commands.
        $this->printed();
        if (file_exists($this->dir . '/Gemfile')) {
        Severity: Minor
        Found in src/ThemeCompile.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function run()
    {
        // Clean bower cache before removing node_modules.
        $result = false;
        if (file_exists($this->dir . '/bower.json')) {
        Severity: Minor
        Found in src/ThemeClean.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Missing class import via use statement (line '154', column '34').
        Open

                $directoryIterator = new \RecursiveDirectoryIterator($this->dir, \RecursiveDirectoryIterator::SKIP_DOTS);
        Severity: Minor
        Found in src/PackageProject.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '156', column '31').
        Open

                $filterIterator = new \CallbackFilterIterator(
        Severity: Minor
        Found in src/PackageProject.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '155', column '34').
        Open

                $recursiveIterator = new \RecursiveIteratorIterator($directoryIterator, \RecursiveIteratorIterator::SELF_FIRST);
        Severity: Minor
        Found in src/PackageProject.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Avoid unused parameters such as '$io'.
        Open

            public function digipolisThemeCompile(ConsoleIO $io, $dir = null, $buildCommand = 'compile')
        Severity: Minor
        Found in src/Robo/Plugin/Commands/DigipolisPackageCommands.php by phpmd

        UnusedFormalParameter

        Since: 0.2

        Avoid passing parameters to methods or constructors and then not using those parameters.

        Example

        class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

        The method run() has an NPath complexity of 384. The configured NPath complexity threshold is 200.
        Open

            public function run()
    {
        // Print the output of the compile commands.
        $this->printed();
        if (file_exists($this->dir . '/Gemfile')) {
        Severity: Minor
        Found in src/ThemeCompile.php by phpmd

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
    function bar() {
        // lots of complicated code
    }
}

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        Avoid unused parameters such as '$io'.
        Open

            public function digipolisPackageProject(ConsoleIO $io, $archiveFile, $dir = null, $opts = ['ignore|i' => ''])
        Severity: Minor
        Found in src/Robo/Plugin/Commands/DigipolisPackageCommands.php by phpmd

        UnusedFormalParameter

        Since: 0.2

        Avoid passing parameters to methods or constructors and then not using those parameters.

        Example

        class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

        Avoid unused parameters such as '$io'.
        Open

            public function digipolisThemeClean(ConsoleIO $io, $dir = null)
        Severity: Minor
        Found in src/Robo/Plugin/Commands/DigipolisPackageCommands.php by phpmd

        UnusedFormalParameter

        Since: 0.2

        Avoid passing parameters to methods or constructors and then not using those parameters.

        Example

        class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

        Avoid unused local variables such as '$grunt'.
        Open

                    $grunt = $this->findExecutable('grunt');
        Severity: Minor
        Found in src/ThemeCompile.php by phpmd

        UnusedLocalVariable

        Since: 0.2

        Detects when a local variable is declared and/or assigned, but not used.

        Example

        class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

        The method run() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
        Open

            public function run()
    {
        // Clean bower cache before removing node_modules.
        $result = false;
        if (file_exists($this->dir . '/bower.json')) {
        Severity: Minor
        Found in src/ThemeClean.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        The method run() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
        Open

            public function run()
    {
        // Print the output of the compile commands.
        $this->printed();
        if (file_exists($this->dir . '/Gemfile')) {
        Severity: Minor
        Found in src/ThemeCompile.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        Line exceeds 120 characters; contains 132 characters
        Open

        class DigipolisPackageCommands extends \Robo\Tasks implements DigipolisPropertiesAwareInterface, \Robo\Contract\ConfigAwareInterface
        Severity: Minor
        Found in src/Robo/Plugin/Commands/DigipolisPackageCommands.php by phpcodesniffer
        Severity
        Category
        Status
        Source
        Language