Sign upLogin

digitalbiblesociety/dbp

View on GitHub
Star
app/Http/Controllers/Bible/BibleFileSetsController.php

Summary

Maintainability
A
2 hrs
Test Coverage

Avoid too many return statements within this method.
Open

            return fractal($this->generateFilesetChapters($fileset, $fileset_chapters, $bible, $asset_id), new FileSetTransformer(), $this->serializer);
Severity: Major
Found in app/Http/Controllers/Bible/BibleFileSetsController.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return $this->reply($fileset_chapters, [], $transaction_id ?? '');
    Severity: Major
    Found in app/Http/Controllers/Bible/BibleFileSetsController.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return $this->setStatusCode(404)->replyWithError('No Fileset Chapters Found for the provided params');
      Severity: Major
      Found in app/Http/Controllers/Bible/BibleFileSetsController.php - About 30 mins to fix

        Function generateFilesetChapters has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private function generateFilesetChapters($fileset, $fileset_chapters, $bible, $asset_id)
    {
        if ($fileset->set_type_code === 'video_stream') {
            foreach ($fileset_chapters as $key => $fileSet_chapter) {
                $fileset_chapters[$key]->file_name = route('v4_video_stream', ['fileset_id' => $fileset->id, 'file_id' => $fileSet_chapter->id]);
        Severity: Minor
        Found in app/Http/Controllers/Bible/BibleFileSetsController.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function signedPath has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private function signedPath($bible, $fileset, $fileset_chapter)
    {
        switch ($fileset->set_type_code) {
            case 'audio_drama':
            case 'audio':
        Severity: Minor
        Found in app/Http/Controllers/Bible/BibleFileSetsController.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status