Sign upLogin

digitalbiblesociety/dbp

View on GitHub
Star
app/Http/Controllers/User/UsersController.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function login has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function login(Request $request)
    {
        if (!$this->api && $request->method() !== 'POST') {
            return view('auth.login');
        }
Severity: Minor
Found in app/Http/Controllers/User/UsersController.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function update(Request $request, $id)
    {
        if ((int) $request->v === 1) {
            return redirect('http://api.dbp.test/login?reply=json');
        }
Severity: Minor
Found in app/Http/Controllers/User/UsersController.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

                    return $this->setStatusCode(404)->replyWithError(trans('api.projects_404'));
Severity: Major
Found in app/Http/Controllers/User/UsersController.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return $this->reply(['success' => 'User updated', 'user' => $user]);
    Severity: Major
    Found in app/Http/Controllers/User/UsersController.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return $this->setStatusCode(401)->replyWithError(trans('api.projects_developer_not_a_member', [], $GLOBALS['i18n_iso']));
      Severity: Major
      Found in app/Http/Controllers/User/UsersController.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return view('dashboard.users.show', $id);
        Severity: Major
        Found in app/Http/Controllers/User/UsersController.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return $this->setStatusCode(401)->replyWithError(trans('api.projects_users_needs_to_connect', [], $GLOBALS['i18n_iso']));
          Severity: Major
          Found in app/Http/Controllers/User/UsersController.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $this->setStatusCode(401)->replyWithError(trans('auth.failed'));
            Severity: Major
            Found in app/Http/Controllers/User/UsersController.php - About 30 mins to fix

              Function store has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function store(Request $request)
    {
        $invalid = $this->validateUser();
        if ($invalid) {
            return $invalid;
              Severity: Minor
              Found in app/Http/Controllers/User/UsersController.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status