Sign upLogin

digitalheir/bibliography-js

View on GitHub
Star

Showing 101 of 101 total issues

Avoid too many return statements within this function.
Open

    else if (typeof data.data == 'string') return data.string;
Severity: Major
Found in depr/bibtex/field_value/StringValue.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      else if (wordObj.unicode)  return getFirstLetter(wordObj.unicode);
    Severity: Major
    Found in depr/bibtex/field_value/utils.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        else if (wordObj.constructor == Array) return getFirstLetter(flattenToString(wordObj).trim());
      Severity: Major
      Found in depr/bibtex/field_value/utils.js - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function renderVolume(vol, partOfId?: string) {
  return span("_bib_volume", {
      prop: "isPartOf",//    itemType="https://schema.org/PublicationVolume"
    },
    span("_bib_volume_number", {prop: "isPartOf"}, vol)
        Severity: Minor
        Found in src/reference/AMA/html/journal.ts and 1 other location - About 30 mins to fix
        src/reference/MLA/html/journal.ts on lines 17..24

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

          else if (typeof obj === 'string') return obj;
        Severity: Major
        Found in depr/bibtex/field_value/StringValue.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return new Token(ID, chars.join("").trim());
          Severity: Major
          Found in depr/bibtex/lexer/lexer.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                else if (typeof obj === 'object' && obj.type == 'quotedstring') return StringValue.computeUnicodeString(braceDepth, obj.data);
            Severity: Major
            Found in depr/bibtex/field_value/StringValue.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    else return new Token(NUMBER, numString);
              Severity: Major
              Found in depr/bibtex/lexer/lexer.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    else if (obj.constructor === Number) return obj + "";
                Severity: Major
                Found in depr/bibtex/field_value/StringValue.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        if (diacriticHandler) return diacriticHandler(escapeString.substring(2));
                  Severity: Major
                  Found in depr/bibtex/field_value/StringValue.js - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    function renderVolume(vol, partOfId?: string) {
  return span("_bib_volume", {
      prop: "isPartOf",//    itemType="https://schema.org/PublicationVolume"
    },
    span("_bib_volume_number", {prop: "isPartOf"}, vol)
                    Severity: Minor
                    Found in src/reference/MLA/html/journal.ts and 1 other location - About 30 mins to fix
                    src/reference/AMA/html/journal.ts on lines 16..23

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Avoid too many return statements within this function.
                    Open

                      else if (authorToken.constructor == Array) return authorToken.map(flattenToString).join('');
                    Severity: Major
                    Found in depr/bibtex/field_value/utils.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          else if (typeof obj === 'object' && obj.unicode) return obj.unicode;
                      Severity: Major
                      Found in depr/bibtex/field_value/StringValue.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              if (Number.isFinite(number)) return number;
                        Severity: Major
                        Found in depr/bibtex/lexer/lexer.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                            else if (obj.constructor == Number) return obj+"";
                          Severity: Major
                          Found in depr/bibtex/field_value/StringValue.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                return tokens;
                            Severity: Major
                            Found in depr/bibtex/field_value/StringValue.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                    if (specialChar) return specialChar(specialChar);
                              Severity: Major
                              Found in depr/bibtex/field_value/StringValue.js - About 30 mins to fix

                                Function postprocess has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    {"name": "stringreftoken", "symbols": ["stringreftoken$subexpression$1"], "postprocess": function (data, location, reject) { if(typeof data[0][0]=='object') {if(!data[0][0].string)throw new Error("Expected "+data[0]+"to have a 'string' field");return data[0][0].string;} else {if((!(typeof data[0][0] == 'string'||typeof data[0][0]=='number')))throw new Error("Expected "+data[0][0]+" to be a string");return data[0][0]; }}},
                                Severity: Minor
                                Found in depr/bibtex/parser/parser.js - About 25 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Function getStringUntilNonEscapedChar has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                Open

                                  getStringUntilNonEscapedChar(terminalRegex) {
    if (typeof terminalRegex === 'string') {
    }
    const chars = [];
    for (let i = this.pos; i < this.len; i++) {
                                Severity: Minor
                                Found in depr/bibtex/lexer/lexer.js - About 25 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Function flattenToString has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                Open

                                function flattenToString(authorToken) {
  if (typeof authorToken === 'string') return authorToken;
  else if (authorToken.type == 'braced')  return flattenToString(authorToken.data);
  else if (authorToken.type == 'ws') {
    //console.log(authorToken)
                                Severity: Minor
                                Found in depr/bibtex/field_value/utils.js - About 25 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language