Sign upLogin

diowa/icare

View on GitHub
Star

Showing 12 of 12 total issues

Function initMap has 172 lines of code (exceeds 25 allowed). Consider refactoring.
Open

window.initMap = function () {
  class CustomMarker extends google.maps.OverlayView {
    constructor (position, map, opts) {
      super()
      this.position = position
Severity: Major
Found in app/javascript/src/maps.js - About 6 hrs to fix

    Function initGoogleMaps has 107 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const initGoogleMaps = function (id) {
    const lightStyle = [
      { featureType: 'all', stylers: [] },
      {
        featureType: 'road',
    Severity: Major
    Found in app/javascript/src/maps.js - About 4 hrs to fix

      Function initItineraryIndex has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const initItineraryIndex = function () {
  indexItinerariesMapInit('#index-itineraries-map')

  clearItineraries()
      Severity: Major
      Found in app/javascript/src/maps-search.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          $('#new_itinerary [data-validate]:input:visible').each(function () {
    const {
      validators
    } = this.form.ClientSideValidations.settings
    if (!$(this).isValid(validators)) { valid = false }
        Severity: Major
        Found in app/javascript/src/maps-new.js and 1 other location - About 1 hr to fix
        app/javascript/src/maps-new.js on lines 242..247

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            $('[data-validate]:input:visible').each(function () {
      const {
        validators
      } = this.form.ClientSideValidations.settings
      if (!$(this).isValid(validators)) { valid = false }
        Severity: Major
        Found in app/javascript/src/maps-new.js and 1 other location - About 1 hr to fix
        app/javascript/src/maps-new.js on lines 102..107

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function drawPath has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const drawPath = function (itinerary, strokeColor, strokeOpacity) {
  if (strokeColor == null) { strokeColor = '#0000FF' }
  if (strokeOpacity == null) { strokeOpacity = 0.45 }
  icare.latLngBounds.extend(new google.maps.LatLng(itinerary.start_location.lat, itinerary.start_location.lng))
  icare.latLngBounds.extend(new google.maps.LatLng(itinerary.end_location.lat, itinerary.end_location.lng))
        Severity: Minor
        Found in app/javascript/src/maps-search.js - About 1 hr to fix

          Function wizardNextStep has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const wizardNextStep = function () {
  // Run validations
  if ($('#itinerary_route').val() === '') {
    $('#map-error-j').text(i18n.t('javascript.setup_route_first')).show()
    return false
          Severity: Minor
          Found in app/javascript/src/maps-new.js - About 1 hr to fix

            Function calculateRoute has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const calculateRoute = function (dr, ds) {
  if (($('#itinerary_start_address').val() === '') || ($('#itinerary_end_address').val() === '')) { return }
  $('#itineraries-spinner-j').show()
  $('#map-error-j').hide()
  $('#map-result-j').hide()
            Severity: Minor
            Found in app/javascript/src/maps-new.js - About 1 hr to fix

              Function setItinerary has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              const setItinerary = function (route) {
  // NOTE server side is limited to 2.500 requests per day, so we create routes on client

  // Set visible fields at first
  $('.itinerary-from-j').text(route.legs[0].start_address)
              Severity: Minor
              Found in app/javascript/src/maps-new.js - About 1 hr to fix

                Function initMap has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                window.initMap = function () {
  class CustomMarker extends google.maps.OverlayView {
    constructor (position, map, opts) {
      super()
      this.position = position
                Severity: Minor
                Found in app/javascript/src/maps.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function createRouteMapInit has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                const createRouteMapInit = function (id) {
  const map = icare.initGoogleMaps(id)

  const dr = new google.maps.DirectionsRenderer({
    map,
                Severity: Minor
                Found in app/javascript/src/maps-new.js - About 1 hr to fix

                  Function onAdd has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      onAdd () {
      const me = this
      const div = document.createElement('div')
      div.style.position = 'absolute'
                  Severity: Minor
                  Found in app/javascript/src/maps.js - About 1 hr to fix
                    Severity
                    Category
                    Status
                    Source
                    Language