Sign upLogin

distributed-system-analysis/run-perf

View on GitHub
Star
runperf/tests.py

Summary

Maintainability
B
4 hrs
Test Coverage
C
79%

Function __init__ has a Cognitive Complexity of 24 (exceeds 6 allowed). Consider refactoring.
Wontfix

    def __init__(self, host, workers, base_output_path,
                 metadata, extra):
        super().__init__(host, workers, base_output_path, metadata, extra)
        if "pbench_server_publish" in self.metadata:
            self.pbench_publish = True
Severity: Minor
Found in runperf/tests.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity is too high in method setup. (14)
Open

    def setup(self):
        def install_pbench(host, metadata, test):
            with host.get_session_cont() as session:
                session.runperf_stage("Setup pbench")
                pbench.install_on(session, metadata, test=test)
Severity: Minor
Found in runperf/tests.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in method __init__. (14)
Open

    def __init__(self, host, workers, base_output_path,
                 metadata, extra):
        super().__init__(host, workers, base_output_path, metadata, extra)
        if "pbench_server_publish" in self.metadata:
            self.pbench_publish = True
Severity: Minor
Found in runperf/tests.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in method _run. (13)
Open

    def _run(self):
        # We only need one group of workers
        src = None
        try:
            with self.host.get_session_cont() as session:
Severity: Minor
Found in runperf/tests.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, host, workers, base_output_path, metadata, extra):
Severity: Minor
Found in runperf/tests.py - About 45 mins to fix

    Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, host, workers, base_output_path, metadata, extra):
    Severity: Minor
    Found in runperf/tests.py - About 45 mins to fix

      Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, host, workers, base_output_path, metadata, extra):
      Severity: Minor
      Found in runperf/tests.py - About 45 mins to fix

        Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(self, host, workers, base_output_path, metadata, extra):
        Severity: Minor
        Found in runperf/tests.py - About 45 mins to fix

          Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __init__(self, host, workers, base_output_path,
          Severity: Minor
          Found in runperf/tests.py - About 35 mins to fix

            Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def __init__(self, host, workers, base_output_path, metadata, extra):
            Severity: Minor
            Found in runperf/tests.py - About 35 mins to fix

              Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed.
              Wontfix

                  def __init__(self, host, workers, base_output_path,
              Severity: Critical
              Found in runperf/tests.py by sonar-python

              Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

              See

              Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.
              Open

                  def _run(self):
              Severity: Critical
              Found in runperf/tests.py by sonar-python

              Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

              See

              Take the required action to fix the issue indicated by this "FIXME" comment.
              Open

                              # FIXME: Return this when https://github.com/distributed
              Severity: Major
              Found in runperf/tests.py by sonar-python

              FIXME tags are commonly used to mark places where a bug is suspected, but which the developer wants to deal with later.

              Sometimes the developer will not have the time or will simply forget to get back to that tag.

              This rule is meant to track those tags and to ensure that they do not go unnoticed.

              Noncompliant Code Example

              def divide(numerator, denominator):
  return numerator / denominator              # FIXME denominator value might be 0

              See

              Take the required action to fix the issue indicated by this "FIXME" comment.
              Open

                      # FIXME: Workaround missing perl paths
              Severity: Major
              Found in runperf/tests.py by sonar-python

              FIXME tags are commonly used to mark places where a bug is suspected, but which the developer wants to deal with later.

              Sometimes the developer will not have the time or will simply forget to get back to that tag.

              This rule is meant to track those tags and to ensure that they do not go unnoticed.

              Noncompliant Code Example

              def divide(numerator, denominator):
  return numerator / denominator              # FIXME denominator value might be 0

              See

              Take the required action to fix the issue indicated by this "FIXME" comment.
              Open

                      # FIXME: Ugly IPv4-libvirt-bridge-only hack to use main host
              Severity: Major
              Found in runperf/tests.py by sonar-python

              FIXME tags are commonly used to mark places where a bug is suspected, but which the developer wants to deal with later.

              Sometimes the developer will not have the time or will simply forget to get back to that tag.

              This rule is meant to track those tags and to ensure that they do not go unnoticed.

              Noncompliant Code Example

              def divide(numerator, denominator):
  return numerator / denominator              # FIXME denominator value might be 0

              See

              FIXME found
              Open

                      # FIXME: Ugly IPv4-libvirt-bridge-only hack to use main host
              Severity: Minor
              Found in runperf/tests.py by fixme

              FIXME found
              Open

                      # FIXME: Workaround missing perl paths
              Severity: Minor
              Found in runperf/tests.py by fixme

              FIXME found
              Open

                              # FIXME: Return this when https://github.com/distributed
              Severity: Minor
              Found in runperf/tests.py by fixme

              There are no issues that match your filters.

              Category
              Status