Sign upLogin

divyanshyadav/data-structures-again

View on GitHub
Star

Showing 50 of 50 total issues

Function _bfs has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    _bfs(graph, startVertex) {
        let queue = [startVertex]
        this.distTo.set(startVertex, 0)

        while (queue.length > 0) {
Severity: Minor
Found in src/graph/bfs.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function floor has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    floor(key) {
        const floorHelper = (root, key) => {
            if (!root) return null

            const cmp = this.comparator(key, root.data)
Severity: Minor
Found in src/tree/binary-search-tree/BST.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function lca has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    lca(a, b) {
        // Least Common Ancestor
        if (a > b) {
            ;[a, b] = [b, a]
        }
Severity: Minor
Found in src/tree/binary-search-tree/BST.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ceil has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    ceil(key) {
        const ceilHelper = (root, key) => {
            if (!root) return null

            const cmp = this.comparator(key, root.data)
Severity: Minor
Found in src/tree/binary-search-tree/BST.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function rank has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    rank(key) {
        const rankHelper = (root, key) => {
            if (!root) return 0

            const cmp = this.comparator(key, root.data)
Severity: Minor
Found in src/tree/binary-search-tree/BST.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function rectInLeft has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function rectInLeft(root, x1, x2, y1, y2, level) {
Severity: Minor
Found in src/tree/2d-tree/index.js - About 45 mins to fix

    Function rangeSearchHelper has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            function rangeSearchHelper(root, x1, x2, y1, y2, level) {
    Severity: Minor
    Found in src/tree/2d-tree/index.js - About 45 mins to fix

      Function inRect has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function inRect(x, y, x1, x2, y1, y2) {
      Severity: Minor
      Found in src/tree/2d-tree/index.js - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    } else {
                nearestPointHelper(root.right, x, y, level + 1)
                if (minDistanceFromPlane < minDistance) {
                    nearestPointHelper(root.left, x, y, level + 1)
                }
        Severity: Minor
        Found in src/tree/2d-tree/index.js and 1 other location - About 45 mins to fix
        src/tree/2d-tree/index.js on lines 83..88

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (isPointLieInLeftOrBottomPlane(root, level, x, y)) {
                nearestPointHelper(root.left, x, y, level + 1)
                if (minDistanceFromPlane < minDistance) {
                    nearestPointHelper(root.right, x, y, level + 1)
                }
        Severity: Minor
        Found in src/tree/2d-tree/index.js and 1 other location - About 45 mins to fix
        src/tree/2d-tree/index.js on lines 88..93

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function delete has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            delete (data) {
        let cur = this.head
        let prev = null

        while (cur !== null) {
        Severity: Minor
        Found in src/linked-list/index.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function rangeSearch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            rangeSearch(start, end) {
        const result = []

        function rangeSearchHelper(root, start, end) {
            if (!root) return null
        Severity: Minor
        Found in src/tree/binary-search-tree/BST.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function rectInRight has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function rectInRight(root, x1, x2, y1, y2, level) {
        Severity: Minor
        Found in src/tree/2d-tree/index.js - About 45 mins to fix

          Function rangeSearch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              rangeSearch(x1, x2, y1, y2) {
        const result = []
        function rangeSearchHelper(root, x1, x2, y1, y2, level) {
            if (!root) return
          Severity: Minor
          Found in src/tree/2d-tree/index.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function floor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              floor (key) {
        let min = -Infinity

        const helper = (root, key) => {
            if (root === null) {
          Severity: Minor
          Found in src/symbol-table/index.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function heapifyDown has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              heapifyDown (i) {
        let index = i
        while (this.hasLeftChild(index)) {
            let smallerChildIndex = this.getLeftChildIndex(index)
            if (this.hasRightChild(index) &&
          Severity: Minor
          Found in src/heap/index.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function ceil has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              ceil (key) {
        let max = Infinity

        const helper = (root, key) => {
            if (root === null) {
          Severity: Minor
          Found in src/symbol-table/index.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                      return null
          Severity: Major
          Found in src/tree/binary-search-tree/BST.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return root
            Severity: Major
            Found in src/tree/binary-search-tree/BST.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return root
              Severity: Major
              Found in src/tree/binary-search-tree/BST.js - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language