django/django

View on GitHub
django/contrib/admin/filters.py

Summary

Maintainability
C
1 day
Test Coverage

File filters.py has 351 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
This encapsulates the logic for displaying filters in the Django admin.
Filters are specified in models with the "list_filter" option.

Each filter subclass knows how to display a filter for a field that passes a
Severity: Minor
Found in django/contrib/admin/filters.py - About 4 hrs to fix

    Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, field, request, params, model, model_admin, field_path):
    Severity: Minor
    Found in django/contrib/admin/filters.py - About 45 mins to fix

      Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, field, request, params, model, model_admin, field_path):
      Severity: Minor
      Found in django/contrib/admin/filters.py - About 45 mins to fix

        Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(self, field, request, params, model, model_admin, field_path):
        Severity: Minor
        Found in django/contrib/admin/filters.py - About 45 mins to fix

          Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __init__(self, field, request, params, model, model_admin, field_path):
          Severity: Minor
          Found in django/contrib/admin/filters.py - About 45 mins to fix

            Function create has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def create(cls, field, request, params, model, model_admin, field_path):
            Severity: Minor
            Found in django/contrib/admin/filters.py - About 45 mins to fix

              Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def __init__(self, field, request, params, model, model_admin, field_path):
              Severity: Minor
              Found in django/contrib/admin/filters.py - About 45 mins to fix

                Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def __init__(self, field, request, params, model, model_admin, field_path):
                Severity: Minor
                Found in django/contrib/admin/filters.py - About 45 mins to fix

                  Function __init__ has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def __init__(self, field, request, params, model, model_admin, field_path):
                          self.field_generic = '%s__' % field_path
                          self.date_params = {k: v for k, v in params.items() if k.startswith(self.field_generic)}
                  
                          now = timezone.now()
                  Severity: Minor
                  Found in django/contrib/admin/filters.py - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if self.include_empty_choice:
                              yield {
                                  'selected': bool(self.lookup_val_isnull),
                                  'query_string': changelist.get_query_string({self.lookup_kwarg_isnull: 'True'}, [self.lookup_kwarg]),
                                  'display': self.empty_value_display,
                  Severity: Major
                  Found in django/contrib/admin/filters.py and 1 other location - About 1 hr to fix
                  django/contrib/admin/filters.py on lines 414..418

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 38.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if include_none:
                              yield {
                                  'selected': bool(self.lookup_val_isnull),
                                  'query_string': changelist.get_query_string({self.lookup_kwarg_isnull: 'True'}, [self.lookup_kwarg]),
                                  'display': self.empty_value_display,
                  Severity: Major
                  Found in django/contrib/admin/filters.py and 1 other location - About 1 hr to fix
                  django/contrib/admin/filters.py on lines 221..225

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 38.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status