Sign upLogin

django/django

View on GitHub
Star
django/contrib/messages/storage/cookie.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function _store has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def _store(self, messages, response, remove_oldest=True, *args, **kwargs):
        """
        Store the messages to a cookie and return a list of any messages which
        could not be stored.
Severity: Minor
Found in django/contrib/messages/storage/cookie.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function process_messages has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def process_messages(self, obj):
        if isinstance(obj, list) and obj:
            if obj[0] == MessageEncoder.message_key:
                if obj[1]:
                    obj[3] = mark_safe(obj[3])
Severity: Minor
Found in django/contrib/messages/storage/cookie.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _store has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _store(self, messages, response, remove_oldest=True, *args, **kwargs):
Severity: Minor
Found in django/contrib/messages/storage/cookie.py - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status