Sign upLogin

django/django

View on GitHub
Star
django/contrib/postgres/fields/ranges.py

Summary

Maintainability
A
3 hrs
Test Coverage

File ranges.py has 287 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import datetime
import json

from django.contrib.postgres import forms, lookups
from django.db import models
Severity: Minor
Found in django/contrib/postgres/fields/ranges.py - About 2 hrs to fix

    Function to_python has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def to_python(self, value):
        if isinstance(value, str):
            # Assume we're deserializing
            vals = json.loads(value)
            for end in ("lower", "upper"):
    Severity: Minor
    Found in django/contrib/postgres/fields/ranges.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function value_to_string has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def value_to_string(self, obj):
        value = self.value_from_object(obj)
        if value is None:
            return None
        if value.isempty:
    Severity: Minor
    Found in django/contrib/postgres/fields/ranges.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status