django/django

View on GitHub

Showing 2,090 of 2,090 total issues

Avoid deeply nested control flow statements.
Open

                        if isinstance(expr, F) and expr.name in exclude:
                            return
            rhs_expression = expression.replace_expressions(replacements)
Severity: Major
Found in django/contrib/postgres/constraints.py - About 45 mins to fix

    Function to_python has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def to_python(self, value):
            if not value:
                return {}
            if not isinstance(value, dict):
                try:
    Severity: Minor
    Found in django/contrib/postgres/forms/hstore.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, field, request, params, model, model_admin, field_path):
    Severity: Minor
    Found in django/contrib/admin/filters.py - About 45 mins to fix

      Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, field, request, params, model, model_admin, field_path):
      Severity: Minor
      Found in django/contrib/admin/filters.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if site is not None:
                                object_domain = site.domain
                                break
        
            # If all that malarkey found an object domain, use it. Otherwise, fall back
        Severity: Major
        Found in django/contrib/contenttypes/views.py - About 45 mins to fix

          Function display has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def display(
          Severity: Minor
          Found in django/contrib/admin/decorators.py - About 45 mins to fix

            Function choices has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def choices(self, changelist):
                    add_facets = changelist.add_facets
                    facet_counts = self.get_facet_queryset(changelist) if add_facets else None
                    yield {
                        "selected": self.value() is None,
            Severity: Minor
            Found in django/contrib/admin/filters.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                                    if form.has_changed():
                                        obj = self.save_form(request, form, change=True)
                                        self.save_model(request, obj, form, change=True)
                                        self.save_related(request, form, formsets=[], change=True)
                                        change_msg = self.construct_change_message(
            Severity: Major
            Found in django/contrib/admin/options.py - About 45 mins to fix

              Function get_context has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  def get_context(self, name, value, attrs):
                      context = super().get_context(name, value, attrs)
                      rel_to = self.rel.model
                      if self.admin_site.is_registered(rel_to):
                          # The related object is registered with the same AdminSite
              Severity: Minor
              Found in django/contrib/admin/widgets.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function create has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def create(cls, field, request, params, model, model_admin, field_path):
              Severity: Minor
              Found in django/contrib/admin/filters.py - About 45 mins to fix

                Function clean has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    def clean(self, value):
                        cleaned_data = []
                        errors = []
                        if not any(value) and self.required:
                            raise ValidationError(self.error_messages["required"])
                Severity: Minor
                Found in django/contrib/postgres/forms/array.py - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function get_context has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    def get_context(self, name, value, attrs=None):
                        attrs = {} if attrs is None else attrs
                        context = super().get_context(name, value, attrs)
                        if self.is_localized:
                            self.widget.is_localized = self.is_localized
                Severity: Minor
                Found in django/contrib/postgres/forms/array.py - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function log_action has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def log_action(
                Severity: Minor
                Found in django/contrib/admin/models.py - About 45 mins to fix

                  Function process_rhs_params has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def process_rhs_params(self):
                          if self.rhs_params:
                              # Check if a band index was passed in the query argument.
                              if len(self.rhs_params) == (2 if self.lookup_name == "relate" else 1):
                                  self.process_band_indices()
                  Severity: Minor
                  Found in django/contrib/gis/db/models/lookups.py - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function __init__ has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def __init__(self, path=None, cache=0, country=None, city=None):
                          """
                          Initialize the GeoIP object. No parameters are required to use default
                          settings. Keyword arguments may be passed in to customize the locations
                          of the GeoIP datasets.
                  Severity: Minor
                  Found in django/contrib/gis/geoip2.py - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function transform has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def transform(
                          self, srs, driver=None, name=None, resampling="NearestNeighbour", max_error=0.0
                      ):
                          """
                          Return a copy of this raster reprojected into the given spatial
                  Severity: Minor
                  Found in django/contrib/gis/gdal/raster/source.py - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function as_postgresql has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def as_postgresql(self, compiler, connection, **extra_context):
                          clone = self.copy()
                          function = None
                          expr2 = clone.source_expressions[1]
                          geography = self.source_is_geography()
                  Severity: Minor
                  Found in django/contrib/gis/db/models/functions.py - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function metadata has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def metadata(self, value):
                          """
                          Set the metadata. Update only the domains that are contained in the
                          value dictionary.
                          """
                  Severity: Minor
                  Found in django/contrib/gis/gdal/raster/base.py - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function __getitem__ has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def __getitem__(self, index):
                          "Allows use of the index [] operator to get a layer at the index."
                          if isinstance(index, str):
                              try:
                                  layer = capi.get_layer_by_name(self.ptr, force_bytes(index))
                  Severity: Minor
                  Found in django/contrib/gis/gdal/datasource.py - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function feature_kwargs has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def feature_kwargs(self, feat):
                          """
                          Given an OGR Feature, return a dictionary of keyword arguments for
                          constructing the mapped model.
                          """
                  Severity: Minor
                  Found in django/contrib/gis/utils/layermapping.py - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language