Sign upLogin

dlundgren/phagrancy

View on GitHub
Star

Showing 23 of 23 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/**
 * @file
 * Contains Phagrancy\Action\Scope\Box\SendFile
Severity: Major
Found in src/Action/Scope/Box/SendFile.php and 1 other location - About 6 hrs to fix
src/Action/Api/Scope/Box/SendFile.php on lines 1..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 209.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/**
 * @file
 * Contains Phagrancy\Action\Api\Scope\Box\SendFile
Severity: Major
Found in src/Action/Api/Scope/Box/SendFile.php and 1 other location - About 6 hrs to fix
src/Action/Scope/Box/SendFile.php on lines 1..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 209.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/**
 * @file
 * Contains Phagrancy\Action\Scope\Box\Definition
Severity: Major
Found in src/Action/Scope/Box/Definition.php and 1 other location - About 3 hrs to fix
src/Action/Api/Scope/Box/Definition.php on lines 1..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 145.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/**
 * @file
 * Contains Phagrancy\Action\Api\Scope\Box\Definition
Severity: Major
Found in src/Action/Api/Scope/Box/Definition.php and 1 other location - About 3 hrs to fix
src/Action/Scope/Box/Definition.php on lines 1..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 145.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/**
 * @file
 * Contains Phagrancy\Model\Input\BoxUpload
Severity: Major
Found in src/Model/Input/BoxUpload.php and 1 other location - About 3 hrs to fix
src/Model/Input/BoxDelete.php on lines 1..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/**
 * @file
 * Contains Phagrancy\Model\Input\BoxDelete
Severity: Major
Found in src/Model/Input/BoxDelete.php and 1 other location - About 3 hrs to fix
src/Model/Input/BoxUpload.php on lines 1..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method register has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function register(Container $di)
    {
        $envFile = "{$this->rootPath}/.env";
        if (file_exists($envFile)) {
            $envLoader = new Loader("{$this->rootPath}/.env");
Severity: Major
Found in src/ServiceProvider/Pimple.php - About 2 hrs to fix

    Method __construct has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct($container = [])
    {
        parent::__construct($container);

        // @formatter:off
    Severity: Minor
    Found in src/App.php - About 1 hr to fix

      Method __invoke has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __invoke(ServerRequestInterface $request)
    {
        /**
         * The route controls these params, and they are validated so safe
         *
      Severity: Minor
      Found in src/Action/Api/Scope/Box/Upload.php - About 1 hr to fix

        Function ofName has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function ofName($name)
    {
        if (empty($name)) {
            return null;
        }
        Severity: Minor
        Found in src/Model/Repository/Scope.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __invoke has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function __invoke(ServerRequestInterface $request)
    {
        /**
         * The route controls these params, and they are validated so safe
         *
        Severity: Minor
        Found in src/Action/Api/Scope/Box/Upload.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                    return new Action\Scope\Index($c[Repository\Scope::class], new Input\Scope());
        Severity: Major
        Found in src/ServiceProvider/Pimple.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return new Action\Scope\Box\Definition($c[Repository\Box::class], new Input\Box());
          Severity: Major
          Found in src/ServiceProvider/Pimple.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return new Action\Scopes($c[Repository\Scope::class], new Input\Scope());
            Severity: Major
            Found in src/ServiceProvider/Pimple.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return new Action\Api\Scope\Box\Upload($c[Repository\Box::class], new Input\BoxUpload(), $c['path.storage']);
              Severity: Major
              Found in src/ServiceProvider/Pimple.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return new Action\Scope\Box\SendFile($c[Repository\Box::class], new Input\BoxUpload(), $c['path.storage']);
                Severity: Major
                Found in src/ServiceProvider/Pimple.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return new Action\Api\Scope\Box\Delete($c[Repository\Box::class], new Input\BoxDelete(), $c['path.storage']);
                  Severity: Major
                  Found in src/ServiceProvider/Pimple.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return new Action\Api\Scope\Box\SendFile($c[Repository\Box::class], new Input\BoxUpload(), $c['path.storage']);
                    Severity: Major
                    Found in src/ServiceProvider/Pimple.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return new Action\Api\Scope\Box\CreateVersion(new Input\BoxVersion());
                      Severity: Major
                      Found in src/ServiceProvider/Pimple.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return new Action\Api\Scope\Index($c[Repository\Scope::class], new Input\Scope());
                        Severity: Major
                        Found in src/ServiceProvider/Pimple.php - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language