Sign upLogin

dmayer/idb

View on GitHub
Star
lib/lib/app.rb

Summary

Maintainability
C
1 day
Test Coverage

Class App has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

  class App
    attr_accessor :uuid, :app_dir, :binary, :cache_dir, :services_map
    attr_reader :data_dir

    def initialize(uuid)
Severity: Minor
Found in lib/lib/app.rb - About 3 hrs to fix

    File app.rb has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require_relative 'plist_util'
require_relative 'app_binary'
require_relative 'CgBI'
require_relative 'ios8_last_launch_services_map_wrapper'
require_relative 'ios10_application_state_db_wrapper'
    Severity: Minor
    Found in lib/lib/app.rb - About 2 hrs to fix

      Method decrypt_binary! has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def decrypt_binary!
      $log.info "Running '#{binary_path}'"
      full_remote_path = binary_path
      $log.error "Decryption failed. Trying using dumpdecrypted..."
      Severity: Minor
      Found in lib/lib/app.rb - About 1 hr to fix

        Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def initialize(uuid)
      @uuid = uuid
      @cache_dir = "#{$tmp_path}/#{uuid}"
      FileUtils.mkdir_p @cache_dir  unless Dir.exist? @cache_dir
        Severity: Minor
        Found in lib/lib/app.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method decrypt_binary! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def decrypt_binary!
      $log.info "Running '#{binary_path}'"
      full_remote_path = binary_path
      $log.error "Decryption failed. Trying using dumpdecrypted..."
        Severity: Minor
        Found in lib/lib/app.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method find_icon has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def find_icon
      # lets try the easy way first...
      icon_name = get_raw_plist_value('CFBundleIconFile')
      return icon_name unless icon_name.nil?
        Severity: Minor
        Found in lib/lib/app.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              unless icon_name.nil?
        if !icon_name["CFBundlePrimaryIcon"].nil? && !icon_name["CFBundlePrimaryIcon"]["CFBundleIconFiles"].nil?
          return icon_name["CFBundlePrimaryIcon"]["CFBundleIconFiles"].sort.last
        end
        Severity: Minor
        Found in lib/lib/app.rb and 1 other location - About 15 mins to fix
        lib/lib/app.rb on lines 131..134

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              unless icon_name.nil?
        if !icon_name["CFBundlePrimaryIcon"].nil? && !icon_name["CFBundlePrimaryIcon"]["CFBundleIconFiles"].nil?
          return icon_name["CFBundlePrimaryIcon"]["CFBundleIconFiles"].sort.last
        end
        Severity: Minor
        Found in lib/lib/app.rb and 1 other location - About 15 mins to fix
        lib/lib/app.rb on lines 123..126

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status