Sign upLogin

dmcouncil/copyable

View on GitHub
Star

Showing 8 of 8 total issues

Method copyable has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def copyable(&block)

        begin
          model_class = self
          # raise an error if the copyable declaration is stated incorrectly
Severity: Minor
Found in lib/copyable/copyable_extension.rb - About 1 hr to fix

    Method copyable has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def copyable(&block)

        begin
          model_class = self
          # raise an error if the copyable declaration is stated incorrectly
    Severity: Minor
    Found in lib/copyable/copyable_extension.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update_other_belongs_to_associations has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

            def update_other_belongs_to_associations(already_updated_key, copied_record)
          copied_record.class.reflect_on_all_associations(:belongs_to).each do |assoc|
            next if assoc.foreign_key == already_updated_key
            id = copied_record.send(assoc.foreign_key)
            if id
    Severity: Minor
    Found in lib/copyable/declarations/associations.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method execute has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def execute(association_list, original_model, new_model, global_override = {}, skip_validations, skip_associations)
    Severity: Minor
    Found in lib/copyable/declarations/associations.rb - About 45 mins to fix

      Method execute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def self.execute(column_list, original_model, new_model, overrides)
        column_list.each do |column, advice|
          # when create_copy! is called, you can pass in a hash of
          # overrides that trumps the instructions in the copyable
          # declaration
      Severity: Minor
      Found in lib/copyable/declarations/columns.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method save! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.save!(new_model, skip_validations=false)
      unless skip_validations || new_model.valid?(:create)
        raise(ActiveRecord::RecordInvalid.new(new_model))
      end
      Severity: Minor
      Found in lib/copyable/saver.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  message = "Error in copyable:associations of "
            message << "#{original_model.class.name}: the association '#{association.name}' "
            message << "only supports the :copy_only_habtm_join_records advice, not the :copy advice, "
            message << "because it is a has_and_belongs_to_many association."
            raise AssociationError.new(message)
      Severity: Minor
      Found in lib/copyable/declarations/associations.rb and 1 other location - About 15 mins to fix
      lib/copyable/declarations/associations.rb on lines 39..43

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  message = "Error in copyable:associations of "
            message << "#{original_model.class.name}: the association '#{association.name}' "
            message << "only supports the :copy advice, not the :copy_only_habtm_join_records advice, "
            message << "because it is not a has_and_belongs_to_many association."
            raise AssociationError.new(message)
      Severity: Minor
      Found in lib/copyable/declarations/associations.rb and 1 other location - About 15 mins to fix
      lib/copyable/declarations/associations.rb on lines 32..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language