Sign upLogin

dnstats/dnstatsio

View on GitHub
Star
dnstats/dnsutils/spf.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function _get_redirect_record has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

def _get_redirect_record(record):
    record = record.replace('"', '')
    parts = record.split(' ')
    for part in parts:
        if part.startswith('redirect='):
Severity: Minor
Found in dnstats/dnsutils/spf.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_spf_stats has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def get_spf_stats(ans: list) -> dict:
    """

    :param ans:
    :return:
Severity: Minor
Found in dnstats/dnsutils/spf.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    for r in ans:
                        if r.startswith('"v=spf'):
                            return r
    return ''
Severity: Major
Found in dnstats/dnsutils/spf.py - About 45 mins to fix

    Refactor this function to reduce its Cognitive Complexity from 21 to the 15 allowed.
    Open

    def _get_redirect_record(record):
    Severity: Critical
    Found in dnstats/dnsutils/spf.py by sonar-python

    Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

    See

    Blank line at end of file
    Open

    Severity: Minor
    Found in dnstats/dnsutils/spf.py by pep8

    Trailing blank lines are superfluous.

    Okay: spam(1)
W391: spam(1)\n

However the last line should end with a new line (warning W292).

    There are no issues that match your filters.

    Category
    Status