Sign upLogin

dnstats/dnstatsio

View on GitHub
Star
dnstats/dnsvalidate/caa.py

Summary

Maintainability
C
1 day
Test Coverage

Function validate has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

def validate(caa_result_set: list, domain: str) -> dict:
    """
    Validate a CAA record set based on RFC 8659

    :param caa_result_set: a list of CAA records as str
Severity: Minor
Found in dnstats/dnsvalidate/caa.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Refactor this function to reduce its Cognitive Complexity from 57 to the 15 allowed.
Open

def validate(caa_result_set: list, domain: str) -> dict:
Severity: Critical
Found in dnstats/dnsvalidate/caa.py by sonar-python

Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

See

Merge this if statement with the enclosing one.
Open

                if not validate_url(value):
Severity: Major
Found in dnstats/dnsvalidate/caa.py by sonar-python

Merging collapsible if statements increases the code's readability.

Noncompliant Code Example

if condition1:
    if condition2:
        # ...

Compliant Solution

if condition1 and condition2:
    # ...

Blank line at end of file
Open

Severity: Minor
Found in dnstats/dnsvalidate/caa.py by pep8

Trailing blank lines are superfluous.

Okay: spam(1)
W391: spam(1)\n

However the last line should end with a new line (warning W292).

There are no issues that match your filters.

Category
Status