Sign upLogin

dnstats/dnstatsio

View on GitHub
Star
dnstats/dnsvalidate/dmarc.py

Summary

Maintainability
D
1 day
Test Coverage

Function validate has a Cognitive Complexity of 77 (exceeds 5 allowed). Consider refactoring.
Open

def validate(dmarc_result_set: list) -> dict:
    dmarc_record_values = dict()
    tag_count = dict()
    errors = list()
    if len(dmarc_result_set) < 1:
Severity: Minor
Found in dnstats/dnsvalidate/dmarc.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if rf != 'afrf':
                        errors.append(DmarcErrors.INVALID_RF_VALUE)
            elif tag == 'ri':
Severity: Major
Found in dnstats/dnsvalidate/dmarc.py - About 45 mins to fix

    Refactor this function to reduce its Cognitive Complexity from 78 to the 15 allowed.
    Open

    def validate(dmarc_result_set: list) -> dict:
    Severity: Critical
    Found in dnstats/dnsvalidate/dmarc.py by sonar-python

    Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

    See

    There are no issues that match your filters.

    Category
    Status