Sign upLogin

dnstats/dnstatsio

View on GitHub
Star
dnstats/dnsvalidate/ns.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function _validate has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def _validate(self) -> {}:
        result = {}
        errors = []
        validated_records = []
        if not self.ns_records or len(self.ns_records) == 0:
Severity: Minor
Found in dnstats/dnsvalidate/ns.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Refactor this function to reduce its Cognitive Complexity from 26 to the 15 allowed.
Open

    def _validate(self) -> {}:
Severity: Critical
Found in dnstats/dnsvalidate/ns.py by sonar-python

Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

See

Do not use bare 'except'
Open

                except:
Severity: Minor
Found in dnstats/dnsvalidate/ns.py by pep8

When catching exceptions, mention specific exceptions when possible.

Okay: except Exception:
Okay: except BaseException:
E722: except:

There are no issues that match your filters.

Category
Status