Sign upLogin

dnstats/dnstatsio

View on GitHub
Star
dnstats/grading/__init__.py

Summary

Maintainability
B
6 hrs
Test Coverage

Function percent_to_letter has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def percent_to_letter(percent: float):
    if percent > 100.0:
        return 'A+'
    elif percent >= 93.0:
        return 'A'
Severity: Minor
Found in dnstats/grading/__init__.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return 'C+'
Severity: Major
Found in dnstats/grading/__init__.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return 'D+'
    Severity: Major
    Found in dnstats/grading/__init__.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return 'D'
      Severity: Major
      Found in dnstats/grading/__init__.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return 'C-'
        Severity: Major
        Found in dnstats/grading/__init__.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return 'B-'
          Severity: Major
          Found in dnstats/grading/__init__.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return 'B'
            Severity: Major
            Found in dnstats/grading/__init__.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return 'C'
              Severity: Major
              Found in dnstats/grading/__init__.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return 'D-'
                Severity: Major
                Found in dnstats/grading/__init__.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return 'F'
                  Severity: Major
                  Found in dnstats/grading/__init__.py - About 30 mins to fix

                    Expected 2 blank lines, found 1
                    Open

                    def full_reduce(grade: Grade) -> Grade:
                    Severity: Minor
                    Found in dnstats/grading/__init__.py by pep8

                    Separate top-level function and class definitions with two blank lines.

                    Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

                    Trailing whitespace
                    Open

                        :param key: key to search for
                    Severity: Minor
                    Found in dnstats/grading/__init__.py by pep8

                    Trailing whitespace is superfluous.

                    The warning returned varies on whether the line itself is blank,
for easier filtering for those who want to indent their blank lines.

Okay: spam(1)\n#
W291: spam(1) \n#
W293: class Foo(object):\n    \n    bang = 12

                    Expected 2 blank lines, found 1
                    Open

                    def half_raise(grade: Grade) -> Grade:
                    Severity: Minor
                    Found in dnstats/grading/__init__.py by pep8

                    Separate top-level function and class definitions with two blank lines.

                    Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

                    Expected 2 blank lines, found 1
                    Open

                    def full_raise(grade: Grade) -> Grade:
                    Severity: Minor
                    Found in dnstats/grading/__init__.py by pep8

                    Separate top-level function and class definitions with two blank lines.

                    Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

                    Expected 2 blank lines, found 1
                    Open

                    def percent_to_letter(percent: float):
                    Severity: Minor
                    Found in dnstats/grading/__init__.py by pep8

                    Separate top-level function and class definitions with two blank lines.

                    Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

                    Expected 2 blank lines, found 1
                    Open

                    def half_reduce(grade: Grade) -> Grade:
                    Severity: Minor
                    Found in dnstats/grading/__init__.py by pep8

                    Separate top-level function and class definitions with two blank lines.

                    Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

                    Trailing whitespace
                    Open

                        :return: 0 if k is in dictt, otherwise
                    Severity: Minor
                    Found in dnstats/grading/__init__.py by pep8

                    Trailing whitespace is superfluous.

                    The warning returned varies on whether the line itself is blank,
for easier filtering for those who want to indent their blank lines.

Okay: spam(1)\n#
W291: spam(1) \n#
W293: class Foo(object):\n    \n    bang = 12

                    There are no issues that match your filters.

                    Category
                    Status