Sign upLogin

dobtco/procure-io

View on GitHub
Star
app/models/event.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Consider simplifying this complex logical expression.
Open

    if (event_type.in?(Event.event_types.only(:your_bid_awarded, :bid_awarded).values) &&
        data[:bid][:award_message]) ||

       # Your bid is dismissed and you're allowed to see the dismissal message
       (event_type == Event.event_types[:your_bid_dismissed] &&
Severity: Major
Found in app/models/event.rb - About 1 hr to fix

    Method calculate_i18n_interpolation_data has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def calculate_i18n_interpolation_data
    return_hash = {}

    attrs = [
      "user.display_name", "bid.vendor.name", "project.title", "vendor.name",
    Severity: Minor
    Found in app/models/event.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method has_additional_text? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def has_additional_text?
       # Bid is awarded and has an award message
    if (event_type.in?(Event.event_types.only(:your_bid_awarded, :bid_awarded).values) &&
        data[:bid][:award_message]) ||
    Severity: Minor
    Found in app/models/event.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status