Sign upLogin

dobtco/procure-io

View on GitHub
Star
app/models/response.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method calculate_sortable_value has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def calculate_sortable_value
    self.sortable_value = case response_field.field_type
    when "date"
      ['year', 'month', 'day'].each { |x| return 0 unless value[x] && !value[x].blank? }
      DateTime.new(value['year'].to_i, value['month'].to_i, value['day'].to_i).to_i rescue 0
Severity: Minor
Found in app/models/response.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method display_value has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def display_value
    case response_field.field_type
    when "price"
      "$#{value}"
    when "date"
Severity: Minor
Found in app/models/response.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status