Sign upLogin

docker/docker

View on GitHub
Star
daemon/cluster/executor/container/container.go

Summary

Maintainability
C
1 day
Test Coverage

File container.go has 586 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package container // import "github.com/docker/docker/daemon/cluster/executor/container"

import (
    "context"
    "errors"
Severity: Minor
Found in daemon/cluster/executor/container/container.go - About 4 hrs to fix

    containerConfig has 25 methods (exceeds 20 allowed). Consider refactoring.
    Open

    type containerConfig struct {
    task                *api.Task
    networksAttachments map[string]*api.NetworkAttachment
}
    Severity: Minor
    Found in daemon/cluster/executor/container/container.go - About 2 hrs to fix

      Function convertMount has 69 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func convertMount(m api.Mount) enginemount.Mount {
    mount := enginemount.Mount{
        Source:   m.Source,
        Target:   m.Target,
        ReadOnly: m.ReadOnly,
      Severity: Minor
      Found in daemon/cluster/executor/container/container.go - About 1 hr to fix

        Method containerConfig.setTask has 5 return statements (exceeds 4 allowed).
        Open

        func (c *containerConfig) setTask(t *api.Task, node *api.NodeDescription) error {
    if t.Spec.GetContainer() == nil && t.Spec.GetAttachment() == nil {
        return exec.ErrRuntimeUnsupported
    }
        Severity: Major
        Found in daemon/cluster/executor/container/container.go - About 35 mins to fix

          Method containerConfig.applyPrivileges has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
          Open

          func (c *containerConfig) applyPrivileges(hc *enginecontainer.HostConfig) {
    privileges := c.spec().Privileges
    if privileges == nil {
        return
    }
          Severity: Minor
          Found in daemon/cluster/executor/container/container.go - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  switch m.BindOptions.Propagation {
        case api.MountPropagationRPrivate:
            mount.BindOptions.Propagation = enginemount.PropagationRPrivate
        case api.MountPropagationPrivate:
            mount.BindOptions.Propagation = enginemount.PropagationPrivate
          Severity: Major
          Found in daemon/cluster/executor/container/container.go and 1 other location - About 1 hr to fix
          daemon/cluster/convert/service.go on lines 59..72

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 164.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status