docker/swarmkit

Method nodePlugin.NodeUnstageVolume has 7 return statements (exceeds 4 allowed).

Open

func (np *nodePlugin) NodeUnstageVolume(ctx context.Context, req *api.VolumeAssignment) error {
    np.mu.Lock()
    defer np.mu.Unlock()
    if !np.staging {
        return nil

Method nodePlugin.init has 6 return statements (exceeds 4 allowed).

Open

func (np *nodePlugin) init(ctx context.Context) error {
    probe, err := np.idClient.Probe(ctx, &csi.ProbeRequest{})
    if err != nil {
        return err
    }

Method nodePlugin.NodeUnpublishVolume has 5 return statements (exceeds 4 allowed).

Open

func (np *nodePlugin) NodeUnpublishVolume(ctx context.Context, req *api.VolumeAssignment) error {
    // Check arguments
    if len(req.VolumeID) == 0 {
        return status.Error(codes.InvalidArgument, "Volume ID missing in request")
    }

Method nodePlugin.NodePublishVolume has 5 return statements (exceeds 4 allowed).

Open

func (np *nodePlugin) NodePublishVolume(ctx context.Context, req *api.VolumeAssignment) error {
    err := capability.CheckArguments(req)
    if err != nil {
        return err
    }

Method nodePlugin.NodeStageVolume has 5 return statements (exceeds 4 allowed).

Open

func (np *nodePlugin) NodeStageVolume(ctx context.Context, req *api.VolumeAssignment) error {
    np.mu.Lock()
    defer np.mu.Unlock()
    if !np.staging {
        return nil

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (np *nodePlugin) connect(ctx context.Context) error {
    // even though this is a unix socket, we must set WithInsecure or the
    // connection will not be allowed.
    cc, err := grpc.DialContext(ctx, np.socket, grpc.WithInsecure())
    if err != nil {

• Read up
  Read up