Sign upLogin

docker/swarmkit

View on GitHub
Star
agent/task.go

Summary

Maintainability
C
1 day
Test Coverage

Method taskManager.run has a Cognitive Complexity of 64 (exceeds 20 allowed). Consider refactoring.
Open

func (tm *taskManager) run(ctx context.Context) {
    ctx, cancelAll := context.WithCancel(ctx)
    defer cancelAll() // cancel all child operations on exit.

    ctx = log.WithModule(ctx, "taskmanager")
Severity: Minor
Found in agent/task.go - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method taskManager.run has 129 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (tm *taskManager) run(ctx context.Context) {
    ctx, cancelAll := context.WithCancel(ctx)
    defer cancelAll() // cancel all child operations on exit.

    ctx = log.WithModule(ctx, "taskmanager")
Severity: Major
Found in agent/task.go - About 4 hrs to fix

    There are no issues that match your filters.

    Category
    Status