Sign upLogin

docker/swarmkit

View on GitHub
Star
manager/allocator/portallocator.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method portAllocator.isPortsAllocatedOnInit has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
Open

func (pa *portAllocator) isPortsAllocatedOnInit(s *api.Service, onInit bool) bool {
    // If service has no user-defined endpoint and allocated endpoint,
    // we assume it is allocated and return true.
    if s.Endpoint == nil && s.Spec.Endpoint == nil {
        return true
Severity: Minor
Found in manager/allocator/portallocator.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method portAllocator.isPortsAllocatedOnInit has 8 return statements (exceeds 4 allowed).
Open

func (pa *portAllocator) isPortsAllocatedOnInit(s *api.Service, onInit bool) bool {
    // If service has no user-defined endpoint and allocated endpoint,
    // we assume it is allocated and return true.
    if s.Endpoint == nil && s.Spec.Endpoint == nil {
        return true
Severity: Major
Found in manager/allocator/portallocator.go - About 50 mins to fix

    Method portSpace.allocate has 5 return statements (exceeds 4 allowed).
    Open

    func (ps *portSpace) allocate(p *api.PortConfig) (err error) {
    if p.PublishedPort != 0 {
        // If it falls in the dynamic port range check out
        // from dynamic port space first.
        if p.PublishedPort >= dynamicPortStart && p.PublishedPort <= dynamicPortEnd {
    Severity: Major
    Found in manager/allocator/portallocator.go - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status