Sign upLogin

docker/swarmkit

View on GitHub
Star
manager/controlapi/ca_rotation.go

Summary

Maintainability
C
7 hrs
Test Coverage

Function validateCAConfig has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
Open

func validateCAConfig(ctx context.Context, securityConfig *ca.SecurityConfig, cluster *api.Cluster) (*api.RootCA, error) {
    newConfig := cluster.Spec.CAConfig.Copy()
    newConfig.SigningCACert = ca.NormalizePEMs(newConfig.SigningCACert) // ensure this is normalized before we use it

    if len(newConfig.SigningCAKey) > 0 && len(newConfig.SigningCACert) == 0 {
Severity: Minor
Found in manager/controlapi/ca_rotation.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validateCAConfig has 80 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func validateCAConfig(ctx context.Context, securityConfig *ca.SecurityConfig, cluster *api.Cluster) (*api.RootCA, error) {
    newConfig := cluster.Spec.CAConfig.Copy()
    newConfig.SigningCACert = ca.NormalizePEMs(newConfig.SigningCACert) // ensure this is normalized before we use it

    if len(newConfig.SigningCAKey) > 0 && len(newConfig.SigningCACert) == 0 {
Severity: Major
Found in manager/controlapi/ca_rotation.go - About 2 hrs to fix

    Function validateCAConfig has 17 return statements (exceeds 4 allowed).
    Open

    func validateCAConfig(ctx context.Context, securityConfig *ca.SecurityConfig, cluster *api.Cluster) (*api.RootCA, error) {
    newConfig := cluster.Spec.CAConfig.Copy()
    newConfig.SigningCACert = ca.NormalizePEMs(newConfig.SigningCACert) // ensure this is normalized before we use it

    if len(newConfig.SigningCAKey) > 0 && len(newConfig.SigningCACert) == 0 {
    Severity: Major
    Found in manager/controlapi/ca_rotation.go - About 1 hr to fix

      Function newRootRotationObject has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func newRootRotationObject(ctx context.Context, securityConfig *ca.SecurityConfig, apiRootCA *api.RootCA, newCARootCA ca.RootCA, extCAs []*api.ExternalCA, version uint64) (*api.RootCA, error) {
      Severity: Minor
      Found in manager/controlapi/ca_rotation.go - About 45 mins to fix

        Function validateHasAtLeastOneExternalCA has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func validateHasAtLeastOneExternalCA(ctx context.Context, externalCAs map[string][]*api.ExternalCA, securityConfig *ca.SecurityConfig,
    wantedCert []byte, desc string) ([]*api.ExternalCA, error) {
        Severity: Minor
        Found in manager/controlapi/ca_rotation.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status