Sign upLogin

docker/swarmkit

View on GitHub
Star
manager/controlapi/config.go

Summary

Maintainability
C
1 day
Test Coverage

Method Server.UpdateConfig has 6 return statements (exceeds 4 allowed).
Open

func (s *Server) UpdateConfig(ctx context.Context, request *api.UpdateConfigRequest) (*api.UpdateConfigResponse, error) {
    if request.ConfigID == "" || request.ConfigVersion == nil {
        return nil, status.Errorf(codes.InvalidArgument, errInvalidArgument.Error())
    }
Severity: Major
Found in manager/controlapi/config.go - About 40 mins to fix

    Method Server.RemoveConfig has 6 return statements (exceeds 4 allowed).
    Open

    func (s *Server) RemoveConfig(ctx context.Context, request *api.RemoveConfigRequest) (*api.RemoveConfigResponse, error) {
    if request.ConfigID == "" {
        return nil, status.Errorf(codes.InvalidArgument, "config ID must be provided")
    }
    Severity: Major
    Found in manager/controlapi/config.go - About 40 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (s *Server) RemoveConfig(ctx context.Context, request *api.RemoveConfigRequest) (*api.RemoveConfigResponse, error) {
    if request.ConfigID == "" {
        return nil, status.Errorf(codes.InvalidArgument, "config ID must be provided")
    }
      Severity: Major
      Found in manager/controlapi/config.go and 1 other location - About 7 hrs to fix
      manager/controlapi/secret.go on lines 192..241

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 502.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      func (s *Server) GetConfig(ctx context.Context, request *api.GetConfigRequest) (*api.GetConfigResponse, error) {
    if request.ConfigID == "" {
        return nil, status.Errorf(codes.InvalidArgument, "config ID must be provided")
    }
      Severity: Major
      Found in manager/controlapi/config.go and 2 other locations - About 2 hrs to fix
      manager/controlapi/extension.go on lines 55..70
      manager/controlapi/resource.go on lines 67..81

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 210.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if request.Filters != nil {
        for _, name := range request.Filters.Names {
            byFilters = append(byFilters, store.ByName(name))
        }
        for _, prefix := range request.Filters.NamePrefixes {
      Severity: Major
      Found in manager/controlapi/config.go and 1 other location - About 1 hr to fix
      manager/controlapi/secret.go on lines 109..120

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 135.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status