docker/swarmkit

View on GitHub
manager/controlapi/network.go

Summary

Maintainability
C
1 day
Test Coverage

Function validateIPAMConfiguration has 7 return statements (exceeds 4 allowed).
Open

func validateIPAMConfiguration(ipamConf *api.IPAMConfig) error {
    if ipamConf == nil {
        return status.Errorf(codes.InvalidArgument, "ipam configuration: cannot be empty")
    }

Severity: Major
Found in manager/controlapi/network.go - About 45 mins to fix

    Method Server.validateNetworkSpec has 6 return statements (exceeds 4 allowed).
    Open

    func (s *Server) validateNetworkSpec(spec *api.NetworkSpec) error {
        if spec == nil {
            return status.Errorf(codes.InvalidArgument, errInvalidArgument.Error())
        }
    
    
    Severity: Major
    Found in manager/controlapi/network.go - About 40 mins to fix

      Method Server.RemoveNetwork has 6 return statements (exceeds 4 allowed).
      Open

      func (s *Server) RemoveNetwork(ctx context.Context, request *api.RemoveNetworkRequest) (*api.RemoveNetworkResponse, error) {
          if request.NetworkID == "" {
              return nil, status.Errorf(codes.InvalidArgument, errInvalidArgument.Error())
          }
      
      
      Severity: Major
      Found in manager/controlapi/network.go - About 40 mins to fix

        Method Server.ListNetworks has 6 return statements (exceeds 4 allowed).
        Open

        func (s *Server) ListNetworks(ctx context.Context, request *api.ListNetworksRequest) (*api.ListNetworksResponse, error) {
            var (
                networks []*api.Network
                err      error
            )
        Severity: Major
        Found in manager/controlapi/network.go - About 40 mins to fix

          Method Server.CreateNetwork has 6 return statements (exceeds 4 allowed).
          Open

          func (s *Server) CreateNetwork(ctx context.Context, request *api.CreateNetworkRequest) (*api.CreateNetworkResponse, error) {
              if err := s.validateNetworkSpec(request.Spec); err != nil {
                  return nil, err
              }
          
          
          Severity: Major
          Found in manager/controlapi/network.go - About 40 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                s.store.View(func(tx store.ReadTx) {
                    switch {
                    case request.Filters != nil && len(request.Filters.Names) > 0:
                        networks, err = store.FindNetworks(tx, buildFilters(store.ByName, request.Filters.Names))
                    case request.Filters != nil && len(request.Filters.NamePrefixes) > 0:
            Severity: Major
            Found in manager/controlapi/network.go and 1 other location - About 3 hrs to fix
            manager/controlapi/cluster.go on lines 211..222

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 249.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if request.Filters != nil {
                    networks = filterNetworks(networks,
                        func(e *api.Network) bool {
                            return filterContains(e.Spec.Annotations.Name, request.Filters.Names)
                        },
            Severity: Major
            Found in manager/controlapi/network.go and 1 other location - About 2 hrs to fix
            manager/controlapi/cluster.go on lines 227..242

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 231.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (s *Server) GetNetwork(ctx context.Context, request *api.GetNetworkRequest) (*api.GetNetworkResponse, error) {
                if request.NetworkID == "" {
                    return nil, status.Errorf(codes.InvalidArgument, errInvalidArgument.Error())
                }
            
            
            Severity: Major
            Found in manager/controlapi/network.go and 1 other location - About 2 hrs to fix
            manager/controlapi/task.go on lines 17..32

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 214.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

            func filterNetworks(candidates []*api.Network, filters ...func(*api.Network) bool) []*api.Network {
                result := []*api.Network{}
            
                for _, c := range candidates {
                    match := true
            Severity: Major
            Found in manager/controlapi/network.go and 5 other locations - About 1 hr to fix
            manager/controlapi/cluster.go on lines 186..203
            manager/controlapi/node.go on lines 59..76
            manager/controlapi/service.go on lines 960..977
            manager/controlapi/task.go on lines 55..72
            manager/controlapi/volume.go on lines 204..220

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 140.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status