Sign upLogin

docker/swarmkit

View on GitHub
Star
manager/controlapi/secret.go

Summary

Maintainability
C
1 day
Test Coverage

Method Server.RemoveSecret has 6 return statements (exceeds 4 allowed).
Open

func (s *Server) RemoveSecret(ctx context.Context, request *api.RemoveSecretRequest) (*api.RemoveSecretResponse, error) {
    if request.SecretID == "" {
        return nil, status.Errorf(codes.InvalidArgument, "secret ID must be provided")
    }
Severity: Major
Found in manager/controlapi/secret.go - About 40 mins to fix

    Method Server.UpdateSecret has 6 return statements (exceeds 4 allowed).
    Open

    func (s *Server) UpdateSecret(ctx context.Context, request *api.UpdateSecretRequest) (*api.UpdateSecretResponse, error) {
    if request.SecretID == "" || request.SecretVersion == nil {
        return nil, status.Errorf(codes.InvalidArgument, errInvalidArgument.Error())
    }
    var secret *api.Secret
    Severity: Major
    Found in manager/controlapi/secret.go - About 40 mins to fix

      Function validateSecretSpec has 6 return statements (exceeds 4 allowed).
      Open

      func validateSecretSpec(spec *api.SecretSpec) error {
    if spec == nil {
        return status.Errorf(codes.InvalidArgument, errInvalidArgument.Error())
    }
    if err := validateConfigOrSecretAnnotations(spec.Annotations); err != nil {
      Severity: Major
      Found in manager/controlapi/secret.go - About 40 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (s *Server) RemoveSecret(ctx context.Context, request *api.RemoveSecretRequest) (*api.RemoveSecretResponse, error) {
    if request.SecretID == "" {
        return nil, status.Errorf(codes.InvalidArgument, "secret ID must be provided")
    }
        Severity: Major
        Found in manager/controlapi/secret.go and 1 other location - About 7 hrs to fix
        manager/controlapi/config.go on lines 184..233

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 502.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            if request.Filters != nil {
        for _, name := range request.Filters.Names {
            byFilters = append(byFilters, store.ByName(name))
        }
        for _, prefix := range request.Filters.NamePrefixes {
        Severity: Major
        Found in manager/controlapi/secret.go and 1 other location - About 1 hr to fix
        manager/controlapi/config.go on lines 109..120

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 135.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status