docker/swarmkit

Method Server.UpdateVolume has 15 return statements (exceeds 4 allowed).

Open

func (s *Server) UpdateVolume(ctx context.Context, request *api.UpdateVolumeRequest) (*api.UpdateVolumeResponse, error) {
    if request.VolumeID == "" {
        return nil, status.Errorf(codes.InvalidArgument, "VolumeID must not be empty")
    }
    if request.Spec == nil {

Method Server.ListVolumes has 9 return statements (exceeds 4 allowed).

Open

func (s *Server) ListVolumes(ctx context.Context, request *api.ListVolumesRequest) (*api.ListVolumesResponse, error) {
    var (
        volumes []*api.Volume
        err     error
    )

Method Server.CreateVolume has 9 return statements (exceeds 4 allowed).

Open

func (s *Server) CreateVolume(ctx context.Context, request *api.CreateVolumeRequest) (*api.CreateVolumeResponse, error) {
    if request.Spec == nil {
        return nil, status.Errorf(codes.InvalidArgument, "spec must not be nil")
    }

Method Server.RemoveVolume has 6 return statements (exceeds 4 allowed).

Open

func (s *Server) RemoveVolume(ctx context.Context, request *api.RemoveVolumeRequest) (*api.RemoveVolumeResponse, error) {
    err := s.store.Update(func(tx store.Tx) error {
        volume := store.GetVolume(tx, request.VolumeID)
        if volume == nil {
            return status.Errorf(codes.NotFound, "volume %s not found", request.VolumeID)

Similar blocks of code found in 6 locations. Consider refactoring.

Open

func filterVolumes(candidates []*api.Volume, filters ...func(*api.Volume) bool) []*api.Volume {
    result := []*api.Volume{}
    for _, c := range candidates {
        match := true
        for _, f := range filters {

• Read up
  Read up