docker/swarmkit

View on GitHub
manager/deallocator/deallocator.go

Summary

Maintainability
A
2 hrs
Test Coverage

Method Deallocator.Run has 53 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (deallocator *Deallocator) Run(ctx context.Context) error {
    var (
        allServices []*api.Service
        allNetworks []*api.Network
    )
Severity: Minor
Found in manager/deallocator/deallocator.go - About 1 hr to fix

    Method Deallocator.Run has 6 return statements (exceeds 4 allowed).
    Open

    func (deallocator *Deallocator) Run(ctx context.Context) error {
        var (
            allServices []*api.Service
            allNetworks []*api.Network
        )
    Severity: Major
    Found in manager/deallocator/deallocator.go - About 40 mins to fix

      Method Deallocator.processNetwork has 5 return statements (exceeds 4 allowed).
      Open

      func (deallocator *Deallocator) processNetwork(ctx context.Context, tx store.Tx, network *api.Network, ignoreServiceID *string) (updated bool, err error) {
          if !network.PendingDelete {
              return
          }
      
      
      Severity: Major
      Found in manager/deallocator/deallocator.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status