Sign upLogin

docker/swarmkit

View on GitHub
Star
manager/logbroker/broker.go

Summary

Maintainability
B
6 hrs
Test Coverage

Method LogBroker.ListenSubscriptions has 58 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (lb *LogBroker) ListenSubscriptions(request *api.ListenSubscriptionsRequest, stream api.LogBroker_ListenSubscriptionsServer) error {
    remote, err := ca.RemoteNode(stream.Context())
    if err != nil {
        return err
    }
Severity: Minor
Found in manager/logbroker/broker.go - About 1 hr to fix

    Method LogBroker.PublishLogs has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
    Open

    func (lb *LogBroker) PublishLogs(stream api.LogBroker_PublishLogsServer) (err error) {
    remote, err := ca.RemoteNode(stream.Context())
    if err != nil {
        return err
    }
    Severity: Minor
    Found in manager/logbroker/broker.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method LogBroker.SubscribeLogs has 52 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (lb *LogBroker) SubscribeLogs(request *api.SubscribeLogsRequest, stream api.Logs_SubscribeLogsServer) error {
    ctx := stream.Context()

    if err := validateSelector(request.Selector); err != nil {
        return err
    Severity: Minor
    Found in manager/logbroker/broker.go - About 1 hr to fix

      Method LogBroker.ListenSubscriptions has 8 return statements (exceeds 4 allowed).
      Open

      func (lb *LogBroker) ListenSubscriptions(request *api.ListenSubscriptionsRequest, stream api.LogBroker_ListenSubscriptionsServer) error {
    remote, err := ca.RemoteNode(stream.Context())
    if err != nil {
        return err
    }
      Severity: Major
      Found in manager/logbroker/broker.go - About 50 mins to fix

        Method LogBroker.PublishLogs has 8 return statements (exceeds 4 allowed).
        Open

        func (lb *LogBroker) PublishLogs(stream api.LogBroker_PublishLogsServer) (err error) {
    remote, err := ca.RemoteNode(stream.Context())
    if err != nil {
        return err
    }
        Severity: Major
        Found in manager/logbroker/broker.go - About 50 mins to fix

          Method LogBroker.SubscribeLogs has 6 return statements (exceeds 4 allowed).
          Open

          func (lb *LogBroker) SubscribeLogs(request *api.SubscribeLogsRequest, stream api.Logs_SubscribeLogsServer) error {
    ctx := stream.Context()

    if err := validateSelector(request.Selector); err != nil {
        return err
          Severity: Major
          Found in manager/logbroker/broker.go - About 40 mins to fix

            Method LogBroker.ListenSubscriptions has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
            Open

            func (lb *LogBroker) ListenSubscriptions(request *api.ListenSubscriptionsRequest, stream api.LogBroker_ListenSubscriptionsServer) error {
    remote, err := ca.RemoteNode(stream.Context())
    if err != nil {
        return err
    }
            Severity: Minor
            Found in manager/logbroker/broker.go - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status