Sign upLogin

docker/swarmkit

View on GitHub
Star
manager/orchestrator/jobs/global/reconciler.go

Summary

Maintainability
D
1 day
Test Coverage

Method Reconciler.ReconcileService has a Cognitive Complexity of 69 (exceeds 20 allowed). Consider refactoring.
Open

func (r *Reconciler) ReconcileService(id string) error {
    var (
        service *api.Service
        cluster *api.Cluster
        tasks   []*api.Task
Severity: Minor
Found in manager/orchestrator/jobs/global/reconciler.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Reconciler.ReconcileService has 138 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (r *Reconciler) ReconcileService(id string) error {
    var (
        service *api.Service
        cluster *api.Cluster
        tasks   []*api.Task
Severity: Major
Found in manager/orchestrator/jobs/global/reconciler.go - About 4 hrs to fix

    Method Reconciler.ReconcileService has 6 return statements (exceeds 4 allowed).
    Open

    func (r *Reconciler) ReconcileService(id string) error {
    var (
        service *api.Service
        cluster *api.Cluster
        tasks   []*api.Task
    Severity: Major
    Found in manager/orchestrator/jobs/global/reconciler.go - About 40 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for _, taskID := range restartTasks {
            if err := batch.Update(func(tx store.Tx) error {
                // get the latest version of the task for the restart
                t := store.GetTask(tx, taskID)
                // if it's deleted, nothing to do
      Severity: Major
      Found in manager/orchestrator/jobs/global/reconciler.go and 1 other location - About 1 hr to fix
      manager/orchestrator/jobs/replicated/reconciler.go on lines 231..247

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 135.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for _, taskID := range removeTasks {
            if err := batch.Update(func(tx store.Tx) error {
                t := store.GetTask(tx, taskID)
                if t == nil {
                    return nil
      Severity: Major
      Found in manager/orchestrator/jobs/global/reconciler.go and 1 other location - About 1 hr to fix
      manager/orchestrator/jobs/replicated/reconciler.go on lines 249..265

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 133.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status