Sign upLogin

docker/swarmkit

View on GitHub
Star
manager/orchestrator/restart/restart.go

Summary

Maintainability
D
1 day
Test Coverage

Method Supervisor.shouldRestart has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
Open

func (r *Supervisor) shouldRestart(ctx context.Context, t *api.Task, service *api.Service) bool {
    // TODO(aluzzardi): This function should not depend on `service`.
    // There are 3 possible restart policies.
    switch orchestrator.RestartCondition(t) {
    case api.RestartOnAny:
Severity: Minor
Found in manager/orchestrator/restart/restart.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Supervisor.shouldRestart has 76 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (r *Supervisor) shouldRestart(ctx context.Context, t *api.Task, service *api.Service) bool {
    // TODO(aluzzardi): This function should not depend on `service`.
    // There are 3 possible restart policies.
    switch orchestrator.RestartCondition(t) {
    case api.RestartOnAny:
Severity: Major
Found in manager/orchestrator/restart/restart.go - About 2 hrs to fix

    Method Supervisor.DelayStart has 72 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (r *Supervisor) DelayStart(ctx context.Context, _ store.Tx, oldTask *api.Task, newTaskID string, delay time.Duration, waitStop bool) <-chan struct{} {
    ctx, cancel := context.WithCancel(context.Background())
    doneCh := make(chan struct{})

    r.mu.Lock()
    Severity: Minor
    Found in manager/orchestrator/restart/restart.go - About 1 hr to fix

      Method Supervisor.Restart has 68 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (r *Supervisor) Restart(ctx context.Context, tx store.Tx, cluster *api.Cluster, service *api.Service, t api.Task) error {
    // TODO(aluzzardi): This function should not depend on `service`.

    // Is the old task still in the process of restarting? If so, wait for
    // its restart delay to elapse, to avoid tight restart loops (for
      Severity: Minor
      Found in manager/orchestrator/restart/restart.go - About 1 hr to fix

        Method Supervisor.Restart has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
        Open

        func (r *Supervisor) Restart(ctx context.Context, tx store.Tx, cluster *api.Cluster, service *api.Service, t api.Task) error {
    // TODO(aluzzardi): This function should not depend on `service`.

    // Is the old task still in the process of restarting? If so, wait for
    // its restart delay to elapse, to avoid tight restart loops (for
        Severity: Minor
        Found in manager/orchestrator/restart/restart.go - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method Supervisor.shouldRestart has 10 return statements (exceeds 4 allowed).
        Open

        func (r *Supervisor) shouldRestart(ctx context.Context, t *api.Task, service *api.Service) bool {
    // TODO(aluzzardi): This function should not depend on `service`.
    // There are 3 possible restart policies.
    switch orchestrator.RestartCondition(t) {
    case api.RestartOnAny:
        Severity: Major
        Found in manager/orchestrator/restart/restart.go - About 1 hr to fix

          Method Supervisor.DelayStart has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func (r *Supervisor) DelayStart(ctx context.Context, _ store.Tx, oldTask *api.Task, newTaskID string, delay time.Duration, waitStop bool) <-chan struct{} {
          Severity: Minor
          Found in manager/orchestrator/restart/restart.go - About 45 mins to fix

            Method Supervisor.Restart has 7 return statements (exceeds 4 allowed).
            Open

            func (r *Supervisor) Restart(ctx context.Context, tx store.Tx, cluster *api.Cluster, service *api.Service, t api.Task) error {
    // TODO(aluzzardi): This function should not depend on `service`.

    // Is the old task still in the process of restarting? If so, wait for
    // its restart delay to elapse, to avoid tight restart loops (for
            Severity: Major
            Found in manager/orchestrator/restart/restart.go - About 45 mins to fix

              Method Supervisor.Restart has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              func (r *Supervisor) Restart(ctx context.Context, tx store.Tx, cluster *api.Cluster, service *api.Service, t api.Task) error {
              Severity: Minor
              Found in manager/orchestrator/restart/restart.go - About 35 mins to fix

                Method Supervisor.waitRestart has 5 return statements (exceeds 4 allowed).
                Open

                func (r *Supervisor) waitRestart(ctx context.Context, oldDelay *delayedStart, cluster *api.Cluster, taskID string) {
    // Wait for the last restart delay to elapse.
    select {
    case <-oldDelay.doneCh:
    case <-ctx.Done():
                Severity: Major
                Found in manager/orchestrator/restart/restart.go - About 35 mins to fix

                  Method Supervisor.UpdatableTasksInSlot has 5 return statements (exceeds 4 allowed).
                  Open

                  func (r *Supervisor) UpdatableTasksInSlot(ctx context.Context, slot orchestrator.Slot, service *api.Service) orchestrator.Slot {
    if len(slot) < 1 {
        return nil
    }
                  Severity: Major
                  Found in manager/orchestrator/restart/restart.go - About 35 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if t.Spec.Restart != nil && t.Spec.Restart.Delay != nil {
            var err error
            restartDelay, err = gogotypes.DurationFromProto(t.Spec.Restart.Delay)
            if err != nil {
                log.G(ctx).WithError(err).Error("invalid restart delay; using default")
                    Severity: Minor
                    Found in manager/orchestrator/restart/restart.go and 1 other location - About 35 mins to fix
                    manager/orchestrator/taskinit/init.go on lines 66..73

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 105.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status