Sign upLogin

docker/swarmkit

View on GitHub
Star
manager/orchestrator/taskinit/init.go

Summary

Maintainability
D
2 days
Test Coverage

Function CheckTasks has a Cognitive Complexity of 81 (exceeds 20 allowed). Consider refactoring.
Open

func CheckTasks(ctx context.Context, s *store.MemoryStore, readTx store.ReadTx, initHandler InitHandler, startSupervisor restart.SupervisorInterface) error {
    instances := make(map[orchestrator.SlotTuple][]*api.Task)
    err := s.Batch(func(batch *store.Batch) error {
        tasks, err := store.FindTasks(readTx, store.All)
        if err != nil {
Severity: Minor
Found in manager/orchestrator/taskinit/init.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function CheckTasks has 100 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func CheckTasks(ctx context.Context, s *store.MemoryStore, readTx store.ReadTx, initHandler InitHandler, startSupervisor restart.SupervisorInterface) error {
    instances := make(map[orchestrator.SlotTuple][]*api.Task)
    err := s.Batch(func(batch *store.Batch) error {
        tasks, err := store.FindTasks(readTx, store.All)
        if err != nil {
Severity: Major
Found in manager/orchestrator/taskinit/init.go - About 3 hrs to fix

    Function CheckTasks has 8 return statements (exceeds 4 allowed).
    Open

    func CheckTasks(ctx context.Context, s *store.MemoryStore, readTx store.ReadTx, initHandler InitHandler, startSupervisor restart.SupervisorInterface) error {
    instances := make(map[orchestrator.SlotTuple][]*api.Task)
    err := s.Batch(func(batch *store.Batch) error {
        tasks, err := store.FindTasks(readTx, store.All)
        if err != nil {
    Severity: Major
    Found in manager/orchestrator/taskinit/init.go - About 50 mins to fix

      Function CheckTasks has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func CheckTasks(ctx context.Context, s *store.MemoryStore, readTx store.ReadTx, initHandler InitHandler, startSupervisor restart.SupervisorInterface) error {
      Severity: Minor
      Found in manager/orchestrator/taskinit/init.go - About 35 mins to fix

        Method tasksByCreationTimestamp.Less has 5 return statements (exceeds 4 allowed).
        Open

        func (t tasksByCreationTimestamp) Less(i, j int) bool {
    if t[i].Meta.CreatedAt == nil {
        return true
    }
    if t[j].Meta.CreatedAt == nil {
        Severity: Major
        Found in manager/orchestrator/taskinit/init.go - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if t.Spec.Restart != nil && t.Spec.Restart.Delay != nil {
                var err error
                restartDelay, err = gogotypes.DurationFromProto(t.Spec.Restart.Delay)
                if err != nil {
                    log.G(ctx).WithError(err).Error("invalid restart delay")
          Severity: Minor
          Found in manager/orchestrator/taskinit/init.go and 1 other location - About 35 mins to fix
          manager/orchestrator/restart/restart.go on lines 177..186

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status